fix: Replacing missing root logging calls with langfuse logger instead#509
Merged
Conversation
|
|
samyxdev
changed the title
Contributor
Author
|
Hey @marcklingen, would you have any feedback on the PR ? It would be much appreciated :) |
Member
|
Thanks for the contribution and ping on this, @maxdeichmann will have a look, sorry for the delay! |
maxdeichmann
approved these changes
Apr 9, 2024
Member
|
Thanks again for your contribution @samyxdev 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found two instances where the root logger from logging was being called, hence making impossible to disable logging from Langfuse externally (ie. in a script using the langfuse package).