Skip to content

fix(prompt): allow "content" prompt var again#559

Closed
fancyweb wants to merge 1 commit into
langfuse:mainfrom
fancyweb:fix/prompt-compil-content-var
Closed

fix(prompt): allow "content" prompt var again#559
fancyweb wants to merge 1 commit into
langfuse:mainfrom
fancyweb:fix/prompt-compil-content-var

Conversation

@fancyweb
Copy link
Copy Markdown
Contributor

One more issue after #543 is that having an existing content prompt var doesn't work anymore:

TypeError: BasePromptClient._compile_template_string() got multiple values for argument 'content'

Let's reallow it 🙏

Comment thread langfuse/model.py

@staticmethod
def _compile_template_string(content: str, **kwargs) -> str:
def _compile_template_string(*args, **kwargs) -> str:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure at all about the way I fixed this since I'm new to Python, I let you handle it if there's a better way 😃

@marcklingen marcklingen requested a review from hassiebp April 10, 2024 14:46
@hassiebp
Copy link
Copy Markdown
Contributor

Thanks a lot for your contribution @fancyweb 🙏🏾 - this issue will be addressed in this PR: #560

@hassiebp hassiebp closed this Apr 10, 2024
@fancyweb fancyweb deleted the fix/prompt-compil-content-var branch April 10, 2024 15:28
@marcklingen
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants