fix(llama-index): handle non-dict case when parsing ChatCompletion usage#840
Merged
fix(llama-index): handle non-dict case when parsing ChatCompletion usage#840
Conversation
…#824) Co-authored-by: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
This PR addresses an important issue in the LlamaIndex integration for Langfuse, specifically in handling usage parsing for different LLM response formats.
- Modified
_parse_usage_from_event_payloadinlangfuse/llama_index/llama_index.pyto handle non-dictresponse.rawcases - Added a check to determine if
response.rawis a dict, usingmodel_dump()if not - Ensures correct extraction of usage information for various LLM response structures
- Improves robustness of the LlamaIndex callback handler for different LLM implementations
- Consider adding or updating tests in
tests/test_llama_index.pyto cover this new case
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.