fix(openai): allow iteration with anext protocol #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
This pull request enhances the OpenAI integration in the Langfuse Python SDK by adding support for the __anext__ protocol in streaming responses.
- Added
__anext__method toLangfuseResponseGeneratorAsyncinlangfuse/openai.pyfor compatibility withanext()built-in function - Implemented handling of
StopAsyncIterationexception in__anext__method to finalize generation - Added new test
test_async_chat_stream_with_anext()intests/test_openai.pyto verify__anext__functionality - Improved existing tests and cleaned up code in
tests/test_openai.py
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Our company is hesitating to introduce langfuse due to this bug. Would you please expedite it? |
|
I implemented a sync iterator. It may fix the test. #887 |
Contributor
Author
|
@sinwoobang Apologies for the delay on this. Will get this merged and released asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.