Skip to content

add huawei obs path_style support#8

Merged
41tair merged 7 commits intolanggenius:mainfrom
myg133:main
Jul 30, 2025
Merged

add huawei obs path_style support#8
41tair merged 7 commits intolanggenius:mainfrom
myg133:main

Conversation

@myg133
Copy link
Contributor

@myg133 myg133 commented Jul 29, 2025

huawei obs private deploy with custom domain, need set path_style manually

@myg133
Copy link
Contributor Author

myg133 commented Jul 29, 2025

#6

oss/oss.go Outdated
AccessKey string
SecretKey string
Server string
PathStyle string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I suggest changing PathStyle to a boolean type just like https://github.com/langgenius/dify-cloud-kit/blob/main/oss/oss.go#L64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok
updated

Copy link
Member

@41tair 41tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@41tair 41tair merged commit ec849b2 into langgenius:main Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants