-
Notifications
You must be signed in to change notification settings - Fork 681
feat(openai_api_compatible): text embedding prefix #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openai_api_compatible): text embedding prefix #2079
Conversation
Allow configuration of document and query prefixes for text embedding. Signed-off-by: Yuichiro Utsumi <utsumi.yuichiro@fujitsu.com>
Summary of ChangesHello @utsumi-fj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a useful feature to allow configuring document and query prefixes for text embeddings in the openai_api_compatible model plugin. The implementation is clean and follows existing patterns. I've found one high-severity issue where an empty prefix would incorrectly add a leading space to texts, which could impact embedding results. I've provided a suggestion to fix this. Otherwise, the changes look good.
| return "" | ||
|
|
||
| def _add_prefix(self, texts: list[str], prefix: str) -> list[str]: | ||
| return [f"{prefix} {text}" for text in texts] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation will add a leading space to each text if the prefix is empty (e.g., f' {text}'). This is likely not the intended behavior and could negatively affect embedding quality. This change ensures prefixes are only added when they are not empty, and avoids creating a new list unnecessarily when no prefix is provided.
| return [f"{prefix} {text}" for text in texts] | |
| return [f"{prefix} {text}" for text in texts] if prefix else texts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed!
Allow configuration of document and query prefixes for text embedding in openai_api_compatible model plugin.
Related Issues or Context
Some embedding models improve accuracy when a prefix is specified. This PR makes it possible to set document and query prefixes.
Note: This pull request can be used even if the dify-plugin-sdk's bug langgenius/dify-plugin-sdks#241 is not yet fixed. Once the bug is fixed, the functionality will behave as intended.
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment