Skip to content

add: source for plugin task query api#628

Merged
zyssyz123 merged 2 commits into
mainfrom
feat/add-source-for-plugin-task
Mar 13, 2026
Merged

add: source for plugin task query api#628
zyssyz123 merged 2 commits into
mainfrom
feat/add-source-for-plugin-task

Conversation

@zyssyz123
Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 9, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the plugin installation and upgrade process by adding a mechanism to track the source of each task. This change allows for better auditing and querying of plugin tasks by providing context about where the task originated, without altering the core logic of how plugins are installed or upgraded.

Highlights

  • Source Tracking for Plugin Tasks: Introduced a new source parameter to track the origin of plugin installation and upgrade tasks.
  • Function Signature Update: The buildTaskStatuses function now accepts a source string, which is then propagated to the task status.
  • Data Model Enhancement: Added a Source field to the InstallTaskPluginStatus struct to store the origin of the plugin task.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • internal/service/install_plugin.go
    • Modified InstallMultiplePluginsToTenant to pass the new source parameter to buildTaskStatuses.
    • Modified UpgradePlugin to pass the new source parameter to buildTaskStatuses.
  • internal/service/install_plugin_utils.go
    • Updated the buildTaskStatuses function signature to accept a source string.
    • Populated the Source field of the InstallTaskPluginStatus with the provided source.
  • internal/types/models/task.go
    • Added a new Source field of type string to the InstallTaskPluginStatus struct.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot Bot added the plugin-daemon label Mar 9, 2026
@zyssyz123 zyssyz123 requested review from Stream29 and Yeuoly and removed request for Yeuoly March 9, 2026 02:46
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a source field to the plugin installation task status, enhancing task origin tracking. No vulnerabilities or significant issues were found in the provided code changes. However, it is recommended to add validation for the new source field to align with existing database schema constraints and prevent potential data integrity issues.

Comment thread internal/service/install_plugin.go
Comment thread internal/service/install_plugin.go
@zyssyz123 zyssyz123 changed the title add source for plugin task query api add: source for plugin task query api Mar 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 13, 2026
@zyssyz123 zyssyz123 merged commit 1283387 into main Mar 13, 2026
7 checks passed
@zyssyz123 zyssyz123 deleted the feat/add-source-for-plugin-task branch March 13, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer plugin-daemon size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants