fix: hardcoded http scheme in Dify-Hook-Url

[s4s7]

Description

Update Dify-Hook-Url handling when empty
Fixes #654

Type of Change

• Bug fix
• New feature
• Refactor
• Performance improvement
• Other

Essential Checklist

Testing

• I have tested the changes locally and confirmed they work as expected
• I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

• I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where the Dify-Hook-Url header was incorrectly hardcoded to use the http scheme, regardless of the original request's protocol. The changes ensure that the Dify-Hook-Url dynamically reflects the correct scheme (http or https) based on the incoming request's TLS state or X-Forwarded-Proto header, enhancing the accuracy and security of generated URLs. Additionally, it introduces a dedicated constant for the header name, improving code readability and reducing potential for typos.

Highlights

• Dynamic Scheme for Dify-Hook-Url: The Dify-Hook-Url header now dynamically determines its scheme (http or https) based on the request's TLS state or the X-Forwarded-Proto header, resolving a bug where it was always hardcoded to http.
• New Header Constant: A new constant, HeaderDifyHookURL, has been introduced in pkg/entities/endpoint_entities/endpoint.go for the Dify-Hook-Url header, improving code maintainability and readability.
• Enhanced Test Coverage: New unit tests were added to internal/service/endpoint_test.go to specifically cover scenarios where the Dify-Hook-Url is empty, ensuring correct scheme generation for both HTTP and HTTPS requests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the copyRequest function to dynamically determine the protocol (HTTP or HTTPS) for the Dify-Hook-Url header based on the request's TLS state or X-Forwarded-Proto header. It also introduces a new constant, HeaderDifyHookURL, for improved maintainability. New unit tests have been added to validate this dynamic protocol determination. A review comment suggests improving the robustness of these new tests by parsing the HTTP request from the buffer and asserting individual components rather than relying on brittle hardcoded string comparisons of the entire request.