Skip to content

perf: not compile .venv and .uv-cache#706

Merged
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-705
Apr 24, 2026
Merged

perf: not compile .venv and .uv-cache#706
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-705

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented Apr 23, 2026

Description

fix #705

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. go Pull requests that update go code plugin-daemon labels Apr 23, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Python pre-compilation logic to exclude .venv and .uv-cache directories by default using the -x flag. It also introduces logic to merge user-provided exclusion patterns from configuration. The review feedback highlights several improvements: escaping literal dots in the regex to prevent matching any character, using strings.Fields for more robust argument parsing, and ensuring that multiple user-provided exclusion patterns are accumulated rather than overwritten.

Comment thread internal/core/local_runtime/setup_python_environment.go Outdated
Comment thread internal/core/local_runtime/setup_python_environment.go Outdated
Comment thread internal/core/local_runtime/setup_python_environment.go
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 23, 2026
@fatelei fatelei merged commit 41f89d2 into langgenius:main Apr 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python compileall exclude .venv and .uv-cache

2 participants