Skip to content

fix: fix dify-plugin-daemon is pid 1#710

Merged
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:pid
Apr 24, 2026
Merged

fix: fix dify-plugin-daemon is pid 1#710
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:pid

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented Apr 24, 2026

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working plugin-daemon labels Apr 24, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tini as the entrypoint in the local Dockerfile to prevent the Python plugin SDK from incorrectly identifying itself as orphaned when running as PID 1. Feedback suggests adding the -g flag to the tini entrypoint to ensure termination signals are properly forwarded to subprocess groups, facilitating graceful shutdowns.

Comment thread docker/local.dockerfile Outdated
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 24, 2026
@fatelei fatelei merged commit b7da835 into langgenius:main Apr 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer plugin-daemon size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants