Skip to content

Conversation

@ZeroZ-lab
Copy link
Contributor

@ZeroZ-lab ZeroZ-lab commented Apr 24, 2025

fix #18649

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 💪 enhancement New feature or request 📚 documentation Improvements or additions to documentation labels Apr 24, 2025
@crazywoola crazywoola requested review from Copilot and laipz8200 April 24, 2025 06:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new remote file upload endpoint that allows files to be uploaded by specifying a remote URL and handles the associated error conditions.

  • Added support for remote file uploads via a new REST API endpoint.
  • Introduced new error handling via a RemoteFileUploadError and used a two-step (HEAD then GET) approach to retrieve remote file data.
  • Updated the imports to include necessary modules for request parsing and remote file handling.
Files not reviewed (12)
  • web/app/components/develop/template/template.en.mdx: Language not supported
  • web/app/components/develop/template/template.ja.mdx: Language not supported
  • web/app/components/develop/template/template.zh.mdx: Language not supported
  • web/app/components/develop/template/template_advanced_chat.en.mdx: Language not supported
  • web/app/components/develop/template/template_advanced_chat.ja.mdx: Language not supported
  • web/app/components/develop/template/template_advanced_chat.zh.mdx: Language not supported
  • web/app/components/develop/template/template_chat.en.mdx: Language not supported
  • web/app/components/develop/template/template_chat.ja.mdx: Language not supported
  • web/app/components/develop/template/template_chat.zh.mdx: Language not supported
  • web/app/components/develop/template/template_workflow.en.mdx: Language not supported
  • web/app/components/develop/template/template_workflow.ja.mdx: Language not supported
  • web/app/components/develop/template/template_workflow.zh.mdx: Language not supported

@laipz8200
Copy link
Member

#18649 (comment)

@ZeroZ-lab ZeroZ-lab closed this May 8, 2025
@ZeroZ-lab ZeroZ-lab deleted the feat-add-remote-file-upload branch July 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation Improvements or additions to documentation 💪 enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The API interfaces in the app support uploading remote files

2 participants