-
Notifications
You must be signed in to change notification settings - Fork 20.1k
CI: use ast-grep rule #29155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CI: use ast-grep rule #29155
Conversation
Summary of ChangesHello @asukaminato0721, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces ast-grep rules to automate the refactoring of SQLAlchemy models to the modern 2.0 style, which is a good improvement for code maintainability. However, the current implementation has a few critical issues. Both new rule files use the same id, which will cause ast-grep to fail. Additionally, the rule for nullable strings contains a logical error in its rewriter that would incorrectly remove the column type definition, leading to broken code. I've provided detailed comments and code suggestions to fix these problems by ensuring unique rule IDs and correcting the rewriter logic. I also recommended more descriptive filenames for better clarity.
Important
Fixes #<issue number>.Summary
Part of #25860, add ast-grep script to auto-rewrite fields.
ref https://ast-grep.github.io/catalog/python/rewrite-sqlalchemy-mapped-column.html
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods