Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 24, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #29575

only one dataset skip rerank

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@fatelei fatelei requested a review from JohnJyong as a code owner December 24, 2025 05:26
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 24, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an optimization to the retrieval process by preventing unnecessary reranking. Specifically, if the system is only working with a single dataset, the second reranking step is now bypassed. This change streamlines the workflow, enhances performance by avoiding redundant processing, and addresses a specific issue related to efficiency in single-dataset scenarios.

Highlights

  • Reranking Optimization: Implemented a condition to skip the reranking process when only a single dataset is being used, improving efficiency and reducing redundant computations.
  • Dataset Count Tracking: Introduced a mechanism to count the number of available datasets, which is then passed to the retrieval thread to inform the reranking decision.
  • Function Signature Update: The _multiple_retrieve_thread function signature was updated to accept the new dataset_count parameter, enabling conditional reranking logic within the thread.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. label Dec 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a performance optimization by skipping the global reranking process when only a single dataset is used for retrieval. The logic is sound and correctly implemented by checking the number of datasets before initiating reranking. My primary feedback is the absence of unit tests for this new conditional logic. While the contribution checklist indicates tests were added, they are not present in the changes. Adding tests is crucial for verifying the behavior and preventing future regressions. I have added a specific comment regarding this.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 24, 2025
@QuantumGhost QuantumGhost changed the title feat: only one dataset skip rerank feat: skip rerank if only one dataset is retrieved Dec 26, 2025
crazywoola
crazywoola previously approved these changes Jan 4, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2026
@crazywoola crazywoola merged commit 473f8ef into langgenius:main Jan 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip the second reranking for knowledge retrieval when there is only one dataset selected

2 participants