-
Notifications
You must be signed in to change notification settings - Fork 19.6k
fix: update Korean translations for various components and improve cl… #30347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Korean translations for various components and improve cl… #30347
Conversation
Summary of ChangesHello @sangyun-han, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update to the Korean localization, addressing inaccuracies and inconsistencies in translation. The changes aim to provide a more natural, professional, and intuitive user experience by fixing mistranslated terms, standardizing technical vocabulary, and refining the overall tone of the user interface. This is purely a text-based change, impacting various Korean i18n JSON files. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is an excellent pull request that significantly improves the quality of the Korean translations. You've done a fantastic job correcting numerous awkward or incorrect machine translations, standardizing technical terminology, and refining the UI text to be more natural and professional. The changes demonstrate a deep understanding of both Korean language nuances and technical software terminology. For instance, fixing critical mistranslations like operation.skip ("배" to "건너뛰기") and serviceApi.disabled ("장애인" to "비활성화됨"), standardizing terms like "completion" to "완료", and improving UI labels (e.g., "적용" instead of "적용하다") will greatly enhance the user experience for Korean-speaking users. The attention to detail across so many files is impressive. Great work!
Summary
This PR improves the Korean localization by correcting mistranslations, standardizing technical terminology, and refining the UI tone to provide a more professional and intuitive user experience.
followed this pr(#30227)
Changes:
Files modified:
Screenshots
N/A - This PR only contains translation text changes.
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods