Skip to content

Conversation

@quicksandznzn
Copy link
Contributor

@quicksandznzn quicksandznzn commented Dec 30, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Fixes #30352

Summary

  • Use workspace editor role to gate template creation in the app template dialog.
  • Remove ExploreContext dependency from the template list.
  • Update template list tests to match the new permission source.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @quicksandznzn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the authorization logic for creating app templates within the web interface. It transitions the permission check from relying on an ExploreContext's hasEditPermission to utilizing the isCurrentWorkspaceEditor status from the AppContext. This change ensures that only users with editor roles in the current workspace are permitted to create templates, streamlining access control and simplifying the underlying permission management.

Highlights

  • Permission Logic Update: The permission mechanism for creating app templates has been updated to use the isCurrentWorkspaceEditor flag from the AppContext.
  • Dependency Removal: The ExploreContext dependency, along with its hasEditPermission property, has been removed from the template list component.
  • Test Updates: Unit tests for the template list component have been adjusted to reflect the new permission source and the canCreate prop passed to AppCard.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the permission logic for creating apps from templates by using the isCurrentWorkspaceEditor role from useAppContext instead of ExploreContext. The changes are clean and well-focused. I've added one suggestion to improve test coverage for the new permission logic, ensuring both allowed and denied scenarios are tested.

@hjlarry hjlarry self-assigned this Dec 30, 2025
Copy link
Contributor

@hjlarry hjlarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 31, 2025
@hjlarry hjlarry merged commit de53c78 into langgenius:main Dec 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After upgrading from version 1.11.0 to 1.11.2, 'Create from Template' doesn't work!

2 participants