fix: fix WorkflowExecution.outputs containing non-JSON-serializable o…

[fatelei]

…bjects causes Logstore persistence failure

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30454

fix WorkflowExecution.outputs containing non-JSON-serializable objects causes Logstore persistence failure

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that prevented workflow execution data from being properly persisted to the Logstore when outputs contained objects that were not directly JSON-serializable. By implementing a custom serialization strategy, the change ensures the robustness and reliability of data storage for workflow executions, preventing potential data loss and improving overall system stability.

Highlights

• Bug Fix: Resolved an issue where WorkflowExecution.outputs containing non-JSON-serializable objects would cause Logstore persistence failures, ensuring all workflow execution data can be reliably stored.
• Serialization Utility: Introduced a new utility function to_serializable that converts non-JSON-serializable objects into JSON-compatible formats by attempting to use to_dict(), __dict__, or falling back to string representation.
• Data Persistence Enhancement: Updated the _to_logstore_model method to utilize the new to_serializable function as a default handler for json.dumps when processing graph, inputs, and outputs fields, preventing serialization errors during log storage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a crash that occurs during log persistence when WorkflowExecution contains non-JSON-serializable objects in its graph, inputs, or outputs. The fix introduces a to_serializable helper function passed to json.dumps to handle such objects. My review focuses on improving the robustness of this new helper function. I've suggested a change to prevent potential infinite recursion and to make the serialization logic safer.