-
Notifications
You must be signed in to change notification settings - Fork 20.2k
feat: agent app support upload video #30590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the agent application by adding comprehensive support for video uploads. It integrates new UI components, manages feature visibility through configuration flags, and provides multilingual support for the new functionality, allowing models to leverage video content for advanced processing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for video uploads in the agent app. The changes include adding a new configuration component for video, updating the context to handle video feature flags, and adding a new video icon. I've found a point of code duplication that could be refactored for better maintainability. Additionally, many internationalization files have been updated with placeholder English text instead of the proper translations. Please address these points.
Important
Fixes #<issue number>.Summary
fix #30570
agent app support upload video
Screenshots
after
Screen.Recording.2026-01-06.at.09.35.07.mov
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods