-
Notifications
You must be signed in to change notification settings - Fork 19.6k
fix: use node factory for single-step workflow nodes #30859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hjlarry, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue causing a 500 error when attempting to execute a single code node within the workflow engine. The fix ensures that code nodes are instantiated with appropriate execution limits, preventing potential resource exhaustion or security vulnerabilities, and thereby enhancing the robustness and reliability of the workflow's code execution capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the single_step_run method in WorkflowEntry to use DifyNodeFactory for creating node instances. This is an excellent change that centralizes node creation logic and correctly handles the instantiation of nodes with specific dependency injection requirements, such as CodeNode. The previous direct instantiation was brittle and would fail for such nodes. A new unit test has been added to verify that CodeNode is correctly configured with its limits during a single-step run, confirming the fix. The changes are well-implemented, improve the code's robustness and maintainability, and I have no further suggestions.
Important
Fixes #<issue number>.Summary
fix #30858
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods