Skip to content

Conversation

@hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jan 12, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30858

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@hjlarry hjlarry requested a review from QuantumGhost as a code owner January 12, 2026 10:07
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 12, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hjlarry, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue causing a 500 error when attempting to execute a single code node within the workflow engine. The fix ensures that code nodes are instantiated with appropriate execution limits, preventing potential resource exhaustion or security vulnerabilities, and thereby enhancing the robustness and reliability of the workflow's code execution capabilities.

Highlights

  • CodeNode Initialization Fix: Corrected the initialization of CodeNode instances in the single_step_run function to properly include CodeNodeLimits.
  • CodeNodeLimits Configuration: Introduced CodeNodeLimits configuration, drawing values from dify_config, to ensure safe execution of code nodes by setting constraints on string length, number values, precision, and array lengths.
  • New Unit Test: Added a new unit test (test_single_step_run_injects_code_limits) to validate that CodeNodeLimits are correctly passed to CodeNode during single-step workflow execution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot]

This comment was marked as outdated.

@hjlarry hjlarry marked this pull request as draft January 12, 2026 11:54
@hjlarry hjlarry changed the title fix: single run code node raise 500 fix: use node factory for single-step workflow nodes Jan 13, 2026
@hjlarry hjlarry marked this pull request as ready for review January 13, 2026 01:31
@hjlarry
Copy link
Contributor Author

hjlarry commented Jan 13, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the single_step_run method in WorkflowEntry to use DifyNodeFactory for creating node instances. This is an excellent change that centralizes node creation logic and correctly handles the instantiation of nodes with specific dependency injection requirements, such as CodeNode. The previous direct instantiation was brittle and would fail for such nodes. A new unit test has been added to verify that CodeNode is correctly configured with its limits during a single-step run, confirming the fix. The changes are well-implemented, improve the code's robustness and maintainability, and I have no further suggestions.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 13, 2026
@crazywoola crazywoola merged commit 837237a into langgenius:main Jan 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

single run code node raise 500

2 participants