Skip to content

Conversation

@cxhello
Copy link
Contributor

@cxhello cxhello commented Jan 20, 2026

Summary

Add @remixicon/react, @lexical/react, and lexical to optimizePackageImports in next.config.js to optimize barrel imports and reduce bundle size.

Changes

  • Added @remixicon/react to optimizePackageImports
  • Added @lexical/react to optimizePackageImports
  • Added lexical to optimizePackageImports

Bundle Size Comparison

Metric Before After Diff
First Load JS (shared) 114 kB 114 kB 0
/account 692 kB 691 kB -1 kB
/activate 367 kB 366 kB -1 kB
/datasets/connect 539 kB 538 kB -1 kB

The optimization effect is minimal because the project likely already has good import practices. However, this change follows Next.js best practices and may provide more significant benefits as the project grows.

Screenshots

N/A - Configuration change only

References

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran cd web && npx lint-staged (frontend) to appease the lint gods

Fixes #31246

@cxhello cxhello requested a review from iamjoel as a code owner January 20, 2026 02:37
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cxhello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Next.js application's build process by configuring optimizePackageImports for several key packages, including UI icons and a rich-text editor library. The primary goal is to improve performance through more efficient module loading and adherence to Next.js best practices, even if the initial impact on bundle size is modest. This proactive optimization sets the stage for better scalability and maintainability.

Highlights

  • Next.js Configuration Update: Added @remixicon/react, @lexical/react, and lexical to the optimizePackageImports array within the experimental section of next.config.js.
  • Bundle Size Optimization: This change aims to optimize barrel imports for the specified packages, potentially reducing the overall bundle size and improving application performance, aligning with Next.js best practices.
  • Minimal Immediate Impact: While the immediate bundle size reduction is noted as minimal (around 1 kB for some routes), the change establishes a foundation for better optimization as the project scales.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds @remixicon/react, @lexical/react, and lexical to the optimizePackageImports configuration in next.config.js. This is a good practice for optimizing barrel imports and potentially reducing the application's bundle size, as recommended by Next.js. The change is correct and beneficial. I've added one suggestion to sort the list of packages alphabetically to improve code maintainability.

Comment on lines 53 to +56
'@heroicons/react',
'@remixicon/react',
'@lexical/react',
'lexical',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and easier maintenance, it's a good practice to keep lists like this sorted alphabetically. This helps in quickly finding an entry and prevents duplicates when the list grows.

Suggested change
'@heroicons/react',
'@remixicon/react',
'@lexical/react',
'lexical',
'@heroicons/react',
'@lexical/react',
'@remixicon/react',
'lexical',

@hyoban
Copy link
Member

hyoban commented Jan 20, 2026

Thank you for your attention, but these packages can't be optimized like that. For example, @remixicon/react doesn't have barrel files. This issue is invalid.

https://www.npmjs.com/package/@remixicon/react?activeTab=code

Let me know if I'm wrong.

@hyoban
Copy link
Member

hyoban commented Jan 20, 2026

In fact, @heroicons/react is included in the default configuration, and we can remove this configuration.

https://nextjs.org/docs/app/api-reference/config/next-config-js/optimizePackageImports#:~:text=%40heroicons/react/20,react/24/outline

#31255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor/Chore] Add @remixicon/react and @lexical/react to optimizePackageImports

2 participants