-
Notifications
You must be signed in to change notification settings - Fork 19.7k
refactor(web): extract useCopyToClipboard hook to reduce duplication #31308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(web): extract useCopyToClipboard hook to reduce duplication #31308
Conversation
Summary of ChangesHello @SherlockShemol, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the codebase by extracting redundant copy-to-clipboard functionality into a single, reusable custom React hook. This change streamlines the implementation of copy features across various UI components, making the code cleaner, more modular, and easier to maintain. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great initiative to reduce code duplication by extracting the copy-to-clipboard logic into a reusable useCopyToClipboard hook. The refactoring is clean and improves maintainability. However, the new hook has a few issues: it introduces a functional regression for one of the components, has a performance issue due to an unstable dependency, and lacks cleanup for debounced functions which could lead to state updates on unmounted components. I've provided detailed comments and suggestions to address these points and make the hook more robust.
hyoban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md#pull-request-process
Please link the issue in the PR description, fixes #<issue_number>
thanks.Done |
hyoban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use https://foxact.skk.moe/use-clipboard/
ff1075e to
a0d07dc
Compare
done.Thanks! |
Replaced duplicated copy-to-clipboard logic across 4 components with foxact's useClipboard hook. Components refactored: - CopyIcon - CopyFeedback - CopyFeedbackNew - InputWithCopy Signed-off-by: SherlockShemol <shemol@163.com>
13d4426 to
7e5b0cc
Compare
The onCopy prop received from parent may be unstable (not wrapped in useCallback), making the useCallback here ineffective.
Closes #31314
Summary
I noticed the copy-to-clipboard logic was duplicated in 4 different components, so I extracted it into a reusable
useCopyToClipboardhook.Changes:
hooks/use-copy-to-clipboard.tswith shared logicCopyIcon,CopyFeedback,CopyFeedbackNew, andInputWithCopyto use the new hookTest plan
pnpm lint:fixpassespnpm type-check:tsgopasses