Skip to content

Conversation

@laipz8200
Copy link
Member

…r to core.app.workflow

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fixes #31610

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project structure by relocating the observability and persistence layers to a more appropriate directory within the core/app/workflow structure. This change improves code organization and maintainability by grouping workflow-related components together. The update also involves adjusting import statements in the affected files to ensure that the application correctly references the relocated layers.

Highlights

  • Refactoring: Moves the observability and persistence layers from core.workflow.graph_engine.layers to core.app.workflow.layers.
  • Import Adjustments: Updates import statements across several files to reflect the new location of the observability and persistence layers.
  • Code Consistency: Ensures that the application's workflow components correctly reference the relocated layers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully refactors the project structure by moving the observability and persistence layers from core.workflow.graph_engine.layers to core.app.workflow.layers. The changes are consistently applied across all affected files, including import statements in application runners, the workflow_entry module, and unit tests. The .importlinter configuration has also been updated to reflect these new module paths. The refactoring appears to be thorough and correctly implemented, maintaining the existing functionality while improving modularity.

@laipz8200 laipz8200 marked this pull request as ready for review January 27, 2026 16:46
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. refactor labels Jan 27, 2026
@asukaminato0721 asukaminato0721 self-requested a review January 27, 2026 16:54
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 27, 2026
@laipz8200 laipz8200 merged commit d76ad15 into main Jan 27, 2026
15 checks passed
@laipz8200 laipz8200 deleted the ignore-import-lint branch January 27, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix ci

3 participants