chore: remove server_default from UUID columns in model definitions#32090
chore: remove server_default from UUID columns in model definitions#32090veeceey wants to merge 1 commit intolanggenius:mainfrom
Conversation
Replace server_default=sa.text(uuid_generate_v4) with default=lambda: str(uuid4()) in TrialApp, AccountTrialAppRecord, and ExporleBanner models to handle UUID generation at the application layer instead of relying on PostgreSQL-specific server defaults. Closes langgenius#29314
Summary of ChangesHello @veeceey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the method of generating UUIDs for several models by shifting the responsibility from the database to the application layer. This change resolves an issue where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly refactors UUID generation for several models to use an application-layer default (uuid.uuid4()) instead of a database-specific server_default. This change improves database agnosticism and aligns the models with the existing convention in the codebase. The implementation is sound and I have no further suggestions.
Summary
Motivation
As described in #29314, the server_default parameter with uuid_generate_v4() is PostgreSQL-specific and causes confusion for new model definitions. The application layer should handle database-agnostic UUID generation using Python uuid4(), which is the established pattern throughout the codebase.
Migration files are intentionally left unchanged as they reflect the actual database state at the time of creation.
Test plan
Closes #29314