Skip to content

chore: remove server_default from UUID columns in model definitions#32090

Open
veeceey wants to merge 1 commit intolanggenius:mainfrom
veeceey:fix/issue-29314-server-default
Open

chore: remove server_default from UUID columns in model definitions#32090
veeceey wants to merge 1 commit intolanggenius:mainfrom
veeceey:fix/issue-29314-server-default

Conversation

@veeceey
Copy link

@veeceey veeceey commented Feb 7, 2026

Summary

  • Remove server_default from UUID column definitions in TrialApp, AccountTrialAppRecord, and ExporleBanner models
  • Replace with default=lambda: str(uuid4()) to handle UUID generation at the application layer
  • Aligns these models with the existing convention used by all other models in the file

Motivation

As described in #29314, the server_default parameter with uuid_generate_v4() is PostgreSQL-specific and causes confusion for new model definitions. The application layer should handle database-agnostic UUID generation using Python uuid4(), which is the established pattern throughout the codebase.

Migration files are intentionally left unchanged as they reflect the actual database state at the time of creation.

Test plan

  • Verified all pre-commit checks pass (Ruff linter, ESLint, TypeScript type-check)
  • Confirmed uuid4 is already imported at the top of the file (from uuid import uuid4)
  • Confirmed the change follows the same pattern as other models in the same file (e.g., App, InstalledApp, RecommendedApp)

Closes #29314

Replace server_default=sa.text(uuid_generate_v4) with
default=lambda: str(uuid4()) in TrialApp, AccountTrialAppRecord,
and ExporleBanner models to handle UUID generation at the application
layer instead of relying on PostgreSQL-specific server defaults.

Closes langgenius#29314
@veeceey veeceey requested a review from QuantumGhost as a code owner February 7, 2026 19:46
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 7, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @veeceey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the method of generating UUIDs for several models by shifting the responsibility from the database to the application layer. This change resolves an issue where server_default relied on PostgreSQL-specific functions, ensuring consistency across the codebase and making the application more portable by using Python's uuid4() for UUID generation.

Highlights

  • UUID Generation Standardization: Removed server_default for UUID columns in TrialApp, AccountTrialAppRecord, and ExporleBanner models.
  • Application-Layer UUIDs: Replaced database-specific UUID generation with default=lambda: str(uuid4()) to handle UUID creation at the application layer.
  • Consistency: This change aligns the UUID generation strategy for these models with the existing convention used by other models in the codebase, promoting a more database-agnostic approach.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • api/models/model.py
    • Modified TrialApp model: Changed id column from server_default=sa.text("uuid_generate_v4()") to default=lambda: str(uuid4()).
    • Modified AccountTrialAppRecord model: Changed id column from server_default=sa.text("uuid_generate_v4()") to default=lambda: str(uuid4()).
    • Modified ExporleBanner model: Changed id column from server_default=sa.text("uuid_generate_v4()") to default=lambda: str(uuid4()).
Activity
  • The author, veeceey, initiated this pull request to address issue [Chore/Refactor] Remove server_default in model definitions #29314, which highlighted the problem with PostgreSQL-specific UUID generation.
  • Pre-commit checks, including Ruff linter, ESLint, and TypeScript type-check, were verified to pass.
  • The presence of uuid4 import was confirmed, ensuring the new default function is valid.
  • The change was confirmed to follow the established pattern of other models within the same file, such as App, InstalledApp, and RecommendedApp.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the refactor label Feb 7, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors UUID generation for several models to use an application-layer default (uuid.uuid4()) instead of a database-specific server_default. This change improves database agnosticism and aligns the models with the existing convention in the codebase. The implementation is sound and I have no further suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore/Refactor] Remove server_default in model definitions

1 participant