Skip to content

feat: squid force ipv4#33556

Merged
crazywoola merged 2 commits intolanggenius:mainfrom
fatelei:issue-33521
Mar 23, 2026
Merged

feat: squid force ipv4#33556
crazywoola merged 2 commits intolanggenius:mainfrom
fatelei:issue-33521

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented Mar 17, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #33521

Screenshots

Before After
... ...

before

image

after

image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Copilot AI review requested due to automatic review settings March 17, 2026 02:27
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 17, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and predictability of the SSRF proxy service by explicitly configuring its network behavior within the Docker environment. It addresses potential host resolution issues and ensures that the Squid proxy consistently uses IPv4 for outgoing connections, which can be crucial for environments where IPv6 might cause unexpected behavior or is not desired. This change aims to resolve a specific issue (#33521) related to the proxy's operation.

Highlights

  • Docker Compose Configuration Update: The ssrf_proxy service in docker-compose.yaml was updated to include extra_hosts for host.docker.internal resolution and sysctls to disable IPv6 for the container.
  • Squid Proxy IPv4 Enforcement: The Squid proxy configuration (squid.conf.template) was modified to explicitly force outgoing connections to use IPv4 by adding tcp_outgoing_address 0.0.0.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docker/docker-compose.yaml
    • Added extra_hosts entry to map host.docker.internal to host-gateway for the ssrf_proxy service.
    • Configured sysctls to disable IPv6 for the ssrf_proxy service.
  • docker/ssrf_proxy/squid.conf.template
    • Appended tcp_outgoing_address 0.0.0.0 to the Squid configuration to explicitly bind outgoing connections to IPv4.
Activity
  • The pull request was opened by fatelei.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to force IPv4 for the Squid proxy to resolve connectivity issues in environments with problematic IPv6 configurations. This is achieved by disabling IPv6 at the container level for the ssrf_proxy service and by configuring Squid to prefer IPv4. The changes in docker-compose.yaml are solid. I have one suggestion for the squid.conf.template to use a more explicit directive for preferring IPv4, which improves readability and maintainability.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to force Squid (SSRF proxy) to use IPv4 for outgoing connections to address issue #33521.

Changes:

  • Adds a tcp_outgoing_address directive to the Squid config template to influence outgoing connection behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 23, 2026
@crazywoola crazywoola merged commit 1b1df37 into langgenius:main Mar 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MCP service exposed from workflow failed, 503 Service Unavailable

3 participants