fix(toast): refine stacked hover and focus styles#33620
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the visual presentation and accessibility of stacked toast components. It modernizes the hover bridge implementation using CSS pseudo-elements, simplifies the component's API, and enhances focus visibility with custom ring styles, ensuring a more consistent and accessible user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR refines the stacked toast interaction styling to better match the Base UI pattern, including replacing the hover “bridge” element with a CSS pseudo-element and updating focus-visible styling to use an explicit ring aligned with the toast/card radius.
Changes:
- Replace the stacked toast “hover bridge” DOM node with an
::afterpseudo-element hit-area. - Simplify
ToastCard/ToastViewportby removing theshowHoverBridgeprop and index-based mapping. - Update toast root focus-visible styling to use an explicit ring and rounded radius.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the stacked toast component by replacing the hover bridge DOM node with a more efficient CSS pseudo-element and improving focus styles. The API is also simplified by removing the showHoverBridge prop. I've added one suggestion to refine the new hover bridge behavior to more closely match the previous implementation by hiding it on the last toast in the stack. Overall, these are solid improvements to the component's maintainability and accessibility.
Summary
Testing