Skip to content

ci: revert agent reporter#33685

Merged
hyoban merged 1 commit intomainfrom
3-18-revert-agent
Mar 18, 2026
Merged

ci: revert agent reporter#33685
hyoban merged 1 commit intomainfrom
3-18-revert-agent

Conversation

@hyoban
Copy link
Member

@hyoban hyoban commented Mar 18, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@hyoban hyoban requested a review from iamjoel as a code owner March 18, 2026 14:12
Copilot AI review requested due to automatic review settings March 18, 2026 14:12
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 18, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a change in the continuous integration configuration by removing the 'agent' reporter from the Vitest setup. This action likely addresses an issue or an unnecessary dependency introduced in a previous commit, streamlining the test reporting process.

Highlights

  • CI Configuration Revert: The 'agent' reporter has been removed from the Vitest configuration in web/vite.config.ts, effectively reverting its previous inclusion.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/web-tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the web This relates to changes on the web. label Mar 18, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 18, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the use of the 'agent' reporter in the Vitest configuration. The change is a straightforward removal of a single line in web/vite.config.ts. As this likely makes the agentation package unused, I've recommended its removal from package.json to maintain dependency hygiene.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the custom “agent” test reporter from the frontend Vitest configuration and the GitHub Actions workflow, reverting CI reporting behavior to the default reporters while keeping coverage generation/merge intact.

Changes:

  • Remove reporters: ['agent'] from web/vite.config.ts Vitest config.
  • Update the web test report merge step to no longer request the agent (or json) reporter during vp test --merge-reports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
web/vite.config.ts Drops the custom Vitest reporter configuration so CI uses standard reporting.
.github/workflows/web-tests.yml Simplifies the merge step command to avoid --reporter=agent during merged test execution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hyoban hyoban merged commit 5ee0633 into main Mar 18, 2026
26 of 27 checks passed
@hyoban hyoban deleted the 3-18-revert-agent branch March 18, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants