Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's code coverage infrastructure by eliminating a custom, in-house system for component-level coverage analysis. The change aims to simplify the continuous integration process and leverage a more standardized, external tool for coverage reporting, reducing maintenance overhead and improving the reliability of coverage metrics. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the custom code coverage checking system, including its associated test files, utility scripts, and configuration within vite.config.ts. This change aligns with the pull request title, indicating a transition to using Codecov. The removal appears clean and does not introduce any new issues in the remaining code.
There was a problem hiding this comment.
Pull request overview
This PR migrates the web CI coverage reporting from a custom app/components diff/baseline coverage gate to Codecov, simplifying the Vitest coverage configuration and removing the bespoke coverage tooling scripts/tests.
Changes:
- Replace custom component diff/baseline coverage steps in
web-tests.ymlwith a Codecov upload step. - Simplify
web/vite.config.tsby removingVITEST_COVERAGE_SCOPE-driven include/exclude logic. - Delete now-unused component coverage scripts and their associated unit tests.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
web/vite.config.ts |
Removes component-coverage scoping logic from Vitest coverage configuration. |
web/scripts/report-components-test-touch.mjs |
Removes obsolete “test touch” reporting script. |
web/scripts/report-components-coverage-baseline.mjs |
Removes obsolete baseline coverage reporting script. |
web/scripts/components-coverage-thresholds.mjs |
Removes obsolete thresholds configuration used by the old gate. |
web/scripts/components-coverage-common.mjs |
Removes shared helpers for the old component coverage tooling. |
web/scripts/component-coverage-filters.mjs |
Removes file filtering logic used by the old component coverage tooling. |
web/scripts/check-components-diff-coverage.mjs |
Removes the old blocking diff coverage gate script. |
web/scripts/check-components-diff-coverage-lib.spec.ts |
Removes unit tests for the old diff coverage lib. |
web/scripts/check-components-diff-coverage-lib.mjs |
Removes the old diff coverage library implementation. |
web/__tests__/components-coverage-common.test.ts |
Removes tests for deleted component coverage helpers. |
web/__tests__/component-coverage-filters.test.ts |
Removes tests for deleted component coverage filters. |
web/__tests__/check-components-diff-coverage.test.ts |
Removes tests for deleted diff coverage helper functions. |
.github/workflows/web-tests.yml |
Switches coverage reporting to Codecov during the merge-reports job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the web test coverage reporting pipeline from custom “app/components” diff/baseline gating scripts to uploading Vitest coverage to Codecov, simplifying CI coverage reporting for the web workspace.
Changes:
- Remove custom component coverage scripts, thresholds, and their associated unit tests.
- Simplify
vite.config.tscoverage configuration by removing theVITEST_COVERAGE_SCOPE=app-componentsspecial-casing. - Update the web CI workflow to upload coverage via
codecov/codecov-action.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
web/vite.config.ts |
Removes component-scope coverage logic and related imports. |
web/scripts/report-components-test-touch.mjs |
Deletes advisory “test touch” reporting script. |
web/scripts/report-components-coverage-baseline.mjs |
Deletes baseline coverage reporting script. |
web/scripts/components-coverage-thresholds.mjs |
Deletes per-module/global threshold configuration. |
web/scripts/components-coverage-common.mjs |
Deletes shared helpers used by the removed coverage tooling. |
web/scripts/component-coverage-filters.mjs |
Deletes component coverage exclusion/filtering logic. |
web/scripts/check-components-diff-coverage.mjs |
Deletes the pure diff coverage gate script. |
web/scripts/check-components-diff-coverage-lib.spec.ts |
Deletes unit tests for removed diff-coverage lib. |
web/scripts/check-components-diff-coverage-lib.mjs |
Deletes diff parsing/coverage computation library. |
web/__tests__/components-coverage-common.test.ts |
Deletes tests for removed component coverage helpers. |
web/__tests__/component-coverage-filters.test.ts |
Deletes tests for removed coverage filter logic. |
web/__tests__/check-components-diff-coverage.test.ts |
Deletes tests for removed diff coverage helpers. |
.github/workflows/web-tests.yml |
Replaces custom coverage steps/artifacts with a Codecov upload step; removes reusable workflow inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR switches the web test coverage reporting approach to use Codecov and removes the repository’s custom app/components coverage gating/reporting scripts and related tests, alongside a few GitHub Action pin bumps.
Changes:
- Replace custom
app/componentsbaseline/diff coverage reporting steps withcodecov/codecov-actionin the web test workflow. - Remove component-coverage scripts, thresholds, and their unit tests; simplify
vitestcoverage config accordingly. - Bump pinned versions/SHAs for several GitHub Actions (UV setup, Claude Code action, anti-slop, setup-vp).
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
web/vite.config.ts |
Removes component-scope coverage configuration and related imports. |
web/scripts/report-components-test-touch.mjs |
Deletes custom “test touch” reporting script. |
web/scripts/report-components-coverage-baseline.mjs |
Deletes baseline coverage reporting script. |
web/scripts/components-coverage-thresholds.mjs |
Deletes stored coverage threshold configuration. |
web/scripts/components-coverage-common.mjs |
Deletes shared helpers for the removed coverage tooling. |
web/scripts/component-coverage-filters.mjs |
Deletes component coverage exclusion logic. |
web/scripts/check-components-diff-coverage.mjs |
Deletes custom diff coverage gate script. |
web/scripts/check-components-diff-coverage-lib.mjs |
Deletes helper library used by the diff coverage gate. |
web/scripts/check-components-diff-coverage-lib.spec.ts |
Removes unit tests for the deleted diff coverage lib. |
web/__tests__/components-coverage-common.test.ts |
Removes tests for deleted component coverage helpers. |
web/__tests__/component-coverage-filters.test.ts |
Removes tests for deleted coverage filters. |
web/__tests__/check-components-diff-coverage.test.ts |
Removes tests for deleted diff coverage logic. |
.github/workflows/web-tests.yml |
Removes custom coverage reporting/gating steps and adds Codecov upload step. |
.github/workflows/main-ci.yml |
Stops passing diff-coverage inputs to web-tests reusable workflow. |
.github/workflows/vdb-tests.yml |
Bumps astral-sh/setup-uv pin. |
.github/workflows/translate-i18n-claude.yml |
Bumps anthropics/claude-code-action pin. |
.github/workflows/style.yml |
Bumps astral-sh/setup-uv pin. |
.github/workflows/pyrefly-diff.yml |
Bumps astral-sh/setup-uv pin. |
.github/workflows/db-migration-test.yml |
Bumps astral-sh/setup-uv pin in both jobs. |
.github/workflows/autofix.yml |
Bumps astral-sh/setup-uv pin. |
.github/workflows/api-tests.yml |
Bumps astral-sh/setup-uv pin. |
.github/workflows/anti-slop.yml |
Pins peakoss/anti-slop to a specific commit SHA. |
.github/actions/setup-web/action.yml |
Pins voidzero-dev/setup-vp to a specific commit SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR introduces Codecov-based coverage reporting for the web test workflow and removes the repository’s custom web/app/components coverage gating/reporting scripts, while also refreshing a few pinned GitHub Action versions.
Changes:
- Switch the web test coverage reporting step to
codecov/codecov-actionand remove the bespoke app/components baseline/diff/test-touch coverage steps. - Remove now-unused component coverage scripts and their unit tests, and simplify Vitest coverage configuration accordingly.
- Update several GitHub Action pins (e.g.,
setup-uv,claude-code-action,anti-slop,setup-vp).
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
web/vite.config.ts |
Removes VITEST_COVERAGE_SCOPE-based include/exclude logic for component-only coverage runs. |
web/scripts/report-components-test-touch.mjs |
Removes legacy “test touch” reporting script. |
web/scripts/report-components-coverage-baseline.mjs |
Removes legacy baseline coverage reporting script. |
web/scripts/components-coverage-thresholds.mjs |
Removes legacy per-module threshold configuration. |
web/scripts/components-coverage-common.mjs |
Removes shared helpers for the legacy component coverage gating pipeline. |
web/scripts/component-coverage-filters.mjs |
Removes legacy logic for excluding component files from coverage gating. |
web/scripts/check-components-diff-coverage.mjs |
Removes legacy diff-coverage gate implementation for web/app/components. |
web/scripts/check-components-diff-coverage-lib.spec.ts |
Removes unit tests for legacy diff-coverage lib. |
web/scripts/check-components-diff-coverage-lib.mjs |
Removes legacy diff-coverage parsing/analysis library. |
web/config/index.ts |
Minor formatting change to VAR_REGEX export. |
web/__tests__/components-coverage-common.test.ts |
Removes tests for deleted legacy coverage helpers. |
web/__tests__/component-coverage-filters.test.ts |
Removes tests for deleted legacy coverage filters. |
web/__tests__/check-components-diff-coverage.test.ts |
Removes tests for deleted legacy diff coverage helpers. |
.github/workflows/web-tests.yml |
Replaces legacy coverage gating/reporting steps with Codecov upload action. |
.github/workflows/main-ci.yml |
Removes now-unused inputs passed to web-tests reusable workflow. |
.github/workflows/api-tests.yml |
Updates astral-sh/setup-uv pin. |
.github/workflows/vdb-tests.yml |
Updates astral-sh/setup-uv pin. |
.github/workflows/style.yml |
Updates astral-sh/setup-uv pin. |
.github/workflows/pyrefly-diff.yml |
Updates astral-sh/setup-uv pin. |
.github/workflows/db-migration-test.yml |
Updates astral-sh/setup-uv pin. |
.github/workflows/autofix.yml |
Updates astral-sh/setup-uv pin. |
.github/workflows/translate-i18n-claude.yml |
Updates anthropics/claude-code-action pin. |
.github/workflows/anti-slop.yml |
Pins peakoss/anti-slop to a specific commit/version. |
.github/actions/setup-web/action.yml |
Updates voidzero-dev/setup-vp pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hyoban
requested review from
Yeuoly,
crazywoola,
iamjoel and
laipz8200
as code owners
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
dosubot
bot
added
the
size:XXL
There was a problem hiding this comment.
Pull request overview
This PR migrates the web test coverage reporting pipeline from a custom “app/components” diff-coverage gate to Codecov-based reporting, simplifying the CI surface area and removing now-unneeded coverage scripts.
Changes:
- Integrate Codecov upload into the
Web Testsreusable workflow and wire it throughmain-civiasecrets: inherit. - Remove the custom component diff-coverage/baseline/test-touch scripts and their associated tests.
- Minor CI dependency pin updates (UV setup action, Claude action, anti-slop, setup-vp) and a small formatting change in
web/config/index.ts.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
web/vite.config.ts |
Removes component-coverage-scope logic from Vitest coverage config. |
web/scripts/report-components-test-touch.mjs |
Deletes advisory “test touch” reporting script. |
web/scripts/report-components-coverage-baseline.mjs |
Deletes baseline coverage summary script. |
web/scripts/components-coverage-thresholds.mjs |
Deletes component coverage thresholds configuration. |
web/scripts/components-coverage-common.mjs |
Deletes shared helpers used by the removed component coverage tooling. |
web/scripts/component-coverage-filters.mjs |
Deletes file classification/filter logic used by the removed tooling. |
web/scripts/check-components-diff-coverage.mjs |
Deletes the “pure diff coverage” gating script. |
web/scripts/check-components-diff-coverage-lib.mjs |
Deletes the library used by the diff coverage script. |
web/scripts/check-components-diff-coverage-lib.spec.ts |
Deletes unit tests for the removed diff-coverage lib. |
web/__tests__/components-coverage-common.test.ts |
Deletes tests for removed component coverage helpers. |
web/__tests__/component-coverage-filters.test.ts |
Deletes tests for removed component coverage filters. |
web/__tests__/check-components-diff-coverage.test.ts |
Deletes tests for removed diff coverage logic. |
.github/workflows/web-tests.yml |
Adds Codecov upload step; removes custom coverage reporting/gating steps. |
.github/workflows/main-ci.yml |
Updates web-tests reusable workflow invocation to secrets: inherit. |
.github/workflows/vdb-tests.yml |
Bumps astral-sh/setup-uv action pin. |
.github/workflows/style.yml |
Bumps astral-sh/setup-uv action pin. |
.github/workflows/pyrefly-diff.yml |
Bumps astral-sh/setup-uv action pin. |
.github/workflows/db-migration-test.yml |
Bumps astral-sh/setup-uv action pin. |
.github/workflows/autofix.yml |
Bumps astral-sh/setup-uv action pin. |
.github/workflows/api-tests.yml |
Bumps astral-sh/setup-uv action pin. |
.github/workflows/translate-i18n-claude.yml |
Bumps anthropics/claude-code-action pin. |
.github/workflows/anti-slop.yml |
Pins peakoss/anti-slop to a commit SHA. |
.github/actions/setup-web/action.yml |
Pins voidzero-dev/setup-vp to a commit SHA. |
web/config/index.ts |
Formats VAR_REGEX declaration to a single line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Report coverage | ||
| if: ${{ env.CODECOV_TOKEN != '' }} | ||
| uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3 | ||
| with: | ||
| name: web-coverage-report | ||
| path: web/coverage | ||
| retention-days: 30 | ||
| if-no-files-found: error | ||
| directory: web/coverage | ||
| flags: web | ||
| env: | ||
| CODECOV_TOKEN: ${{ env.CODECOV_TOKEN }} |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Important
Fixes #<issue number>.Summary
fixes #30351
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods