feat(web): add base ui scroll area primitive#33727
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new base/ui ScrollArea primitive wrapper around @base-ui/react/scroll-area, along with Storybook coverage and a Vitest test suite, to standardize scrollable panel compositions in the web UI.
Changes:
- Added
ScrollAreacompound exports and design-system className defaults (viewport, scrollbar, thumb, corner). - Added comprehensive Storybook stories demonstrating common Dify scroll surface compositions.
- Added unit tests validating rendering and default className behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
web/app/components/base/ui/scroll-area/index.tsx |
Introduces the ScrollArea wrapper/exports and default styling tokens. |
web/app/components/base/ui/scroll-area/index.stories.tsx |
Adds multiple Storybook compositions for vertical, horizontal, overlay, and corner cases. |
web/app/components/base/ui/scroll-area/__tests__/index.spec.tsx |
Adds tests for compound rendering and default className/orientation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hyoban
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods