Skip to content

feat(web): add base ui scroll area primitive#33727

Merged
lyzno1 merged 5 commits intomainfrom
feat/scroll-area
Mar 19, 2026
Merged

feat(web): add base ui scroll area primitive#33727
lyzno1 merged 5 commits intomainfrom
feat/scroll-area

Conversation

@lyzno1
Copy link
Member

@lyzno1 lyzno1 commented Mar 19, 2026

  • feat: base ui scroll bar
  • style: add stories and focus ring
  • update stories
  • update stories

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Copilot AI review requested due to automatic review settings March 19, 2026 04:29
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 19, 2026
@github-actions github-actions bot added the web This relates to changes on the web. label Mar 19, 2026
@dosubot dosubot bot added the 💪 enhancement New feature or request label Mar 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new base/ui ScrollArea primitive wrapper around @base-ui/react/scroll-area, along with Storybook coverage and a Vitest test suite, to standardize scrollable panel compositions in the web UI.

Changes:

  • Added ScrollArea compound exports and design-system className defaults (viewport, scrollbar, thumb, corner).
  • Added comprehensive Storybook stories demonstrating common Dify scroll surface compositions.
  • Added unit tests validating rendering and default className behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
web/app/components/base/ui/scroll-area/index.tsx Introduces the ScrollArea wrapper/exports and default styling tokens.
web/app/components/base/ui/scroll-area/index.stories.tsx Adds multiple Storybook compositions for vertical, horizontal, overlay, and corner cases.
web/app/components/base/ui/scroll-area/__tests__/index.spec.tsx Adds tests for compound rendering and default className/orientation behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Mar 19, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2026
@lyzno1 lyzno1 merged commit f9615b3 into main Mar 19, 2026
22 checks passed
@lyzno1 lyzno1 deleted the feat/scroll-area branch March 19, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants