Skip to content

refactor: use EnumText(StorageType) for UploadFile.storage_type#33728

Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom
tmimmanuel:refactor/enum-storage-type
Mar 19, 2026
Merged

refactor: use EnumText(StorageType) for UploadFile.storage_type#33728
asukaminato0721 merged 1 commit intolanggenius:mainfrom
tmimmanuel:refactor/enum-storage-type

Conversation

@tmimmanuel
Copy link
Contributor

@tmimmanuel tmimmanuel commented Mar 19, 2026

Summary

  • Replace sa.String with EnumText(StorageType) for UploadFile.storage_type in model.py
  • Wrap dify_config.STORAGE_TYPE with StorageType(...) at all 6 assignment sites
  • Update 12 test files to use StorageType.LOCAL instead of "local" string literals

Continues #33294 (model domain — StorageType)

Details

Reuses the existing StorageType enum from extensions/storage/storage_type.py — no new enum class needed.

Test plan

  • basedpyright passes (0 errors on changed files)
  • 105 unit tests pass

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 19, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. refactor labels Mar 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-19 04:35:36.377243459 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-19 04:35:27.320323580 +0000
@@ -438,11 +438,11 @@
 ERROR `None` is not subscriptable [unsupported-operation]
    --> core/rag/extractor/watercrawl/provider.py:141:16
 ERROR Pyrefly detected conflicting types while breaking a dependency cycle: `str | Any | None` is not assignable to `None`. Adding explicit type annotations might possibly help. [bad-assignment]
-   --> core/rag/extractor/word_extractor.py:371:13
+   --> core/rag/extractor/word_extractor.py:372:13
 ERROR Pyrefly detected conflicting types while breaking a dependency cycle: `str | Any | None` is not assignable to `None`. Adding explicit type annotations might possibly help. [bad-assignment]
-   --> core/rag/extractor/word_extractor.py:392:25
+   --> core/rag/extractor/word_extractor.py:393:25
 ERROR Object of class `BaseOxmlElement` has no attribute `body` [missing-attribute]
-   --> core/rag/extractor/word_extractor.py:425:24
+   --> core/rag/extractor/word_extractor.py:426:24
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:194:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -513,6 +513,8 @@
   --> extensions/storage/huawei_obs_storage.py:31:20
 ERROR Argument `Module[Crypto.Hash.SHA1] | Unknown` is not assignable to parameter with type `Hash | HashModule` [bad-argument-type]
   --> libs/gmpy2_pkcs10aep_cipher.py:73:49
+ERROR Argument `str` is not assignable to parameter `value` with type `SQLCoreOperations[StorageType] | StorageType` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
+    --> models/model.py:2173:29
 ERROR No matching overload found for function `redis.client.Redis.__init__` called with arguments: (host=int | str | Unknown, port=int | str | Unknown, password=int | str | Unknown | None, db=int, ssl=bool, ssl_ca_certs=str | None, ssl_cert_reqs=Any | None, ssl_certfile=Any | None, ssl_keyfile=Any | None, socket_timeout=Literal[5], socket_connect_timeout=Literal[5], health_check_interval=Literal[30]) [no-matching-overload]
   --> schedule/queue_monitor_task.py:14:21
 ERROR Object of class `Tenant` has no attribute `role` [missing-attribute]
@@ -606,15 +608,15 @@
 ERROR `unpatch` may be uninitialized [unbound-name]
   --> tests/integration_tests/plugin/__mock/http.py:62:9
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:609:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:610:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:619:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:620:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:630:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:631:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:639:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:640:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:805:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:806:21
 ERROR Argument `Index | None` is not assignable to parameter `index` with type `Index` in function `tcvectordb.rpc.model.collection.RPCCollection.__init__` [bad-argument-type]
   --> tests/integration_tests/vdb/__mock/tcvectordb.py:90:13
 ERROR Argument `xinference_client.types.Embedding | None` is not assignable to parameter `embedding` with type `tcvectordb.model.collection_view.Embedding` in function `tcvectordb.rpc.model.collection.RPCCollection.__init__` [bad-argument-type]
@@ -1162,9 +1164,9 @@
 ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_end_user_service.py:37:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_file_service.py:68:20
+  --> tests/test_containers_integration_tests/services/test_file_service.py:69:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_file_service.py:77:20
+  --> tests/test_containers_integration_tests/services/test_file_service.py:78:20
 ERROR Argument `str` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_human_input_delivery_test.py:32:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
@@ -1534,57 +1536,57 @@
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/tasks/test_add_document_to_index_task.py:62:20
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:70:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:71:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:79:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:80:20
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:292:23
+   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:293:23
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:666:27
+   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:667:27
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:95:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:96:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:104:20
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:105:20
 ERROR `>` is not supported between `None` and `Literal[0]` [unsupported-operation]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:311:16
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:312:16
 ERROR `>` is not supported between `None` and `Literal[0]` [unsupported-operation]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:703:16
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:704:16
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:110:20
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:111:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:120:20
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:121:20
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:295:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:296:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:298:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:299:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:407:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:408:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:410:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:411:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:475:36
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:476:36
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:478:26
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:479:26
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:530:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:531:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:533:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:534:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:615:36
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:616:36
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:618:26
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:619:26
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:728:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:729:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:731:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:732:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:814:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:815:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:817:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:818:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:969:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:970:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:972:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:973:22
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
   --> tests/test_containers_integration_tests/tasks/test_clean_notion_document_task.py:89:23
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
@@ -1966,7 +1968,7 @@
 ERROR Object of class `tuple` has no attribute `json` [missing-attribute]
    --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:192:16
 ERROR Object of class `BadRequest` has no attribute `data` [missing-attribute]
-    --> tests/unit_tests/controllers/console/datasets/test_datasets.py:1634:16
+    --> tests/unit_tests/controllers/console/datasets/test_datasets.py:1635:16
 ERROR Module `services.errors.chunk` exists, but was not imported explicitly. You are relying on other modules to load it. [implicit-import]
    --> tests/unit_tests/controllers/console/datasets/test_datasets_segments.py:891:29
 ERROR Module `services.errors.chunk` exists, but was not imported explicitly. You are relying on other modules to load it. [implicit-import]

@tmimmanuel tmimmanuel force-pushed the refactor/enum-storage-type branch from 0604d5f to ca4e2a9 Compare March 19, 2026 04:49
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-19 04:50:24.354169155 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-19 04:50:14.591121054 +0000
@@ -438,11 +438,11 @@
 ERROR `None` is not subscriptable [unsupported-operation]
    --> core/rag/extractor/watercrawl/provider.py:141:16
 ERROR Pyrefly detected conflicting types while breaking a dependency cycle: `str | Any | None` is not assignable to `None`. Adding explicit type annotations might possibly help. [bad-assignment]
-   --> core/rag/extractor/word_extractor.py:371:13
+   --> core/rag/extractor/word_extractor.py:372:13
 ERROR Pyrefly detected conflicting types while breaking a dependency cycle: `str | Any | None` is not assignable to `None`. Adding explicit type annotations might possibly help. [bad-assignment]
-   --> core/rag/extractor/word_extractor.py:392:25
+   --> core/rag/extractor/word_extractor.py:393:25
 ERROR Object of class `BaseOxmlElement` has no attribute `body` [missing-attribute]
-   --> core/rag/extractor/word_extractor.py:425:24
+   --> core/rag/extractor/word_extractor.py:426:24
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:194:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -606,15 +606,15 @@
 ERROR `unpatch` may be uninitialized [unbound-name]
   --> tests/integration_tests/plugin/__mock/http.py:62:9
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:609:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:610:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:619:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:620:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:630:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:631:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:639:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:640:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:805:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:806:21
 ERROR Argument `Index | None` is not assignable to parameter `index` with type `Index` in function `tcvectordb.rpc.model.collection.RPCCollection.__init__` [bad-argument-type]
   --> tests/integration_tests/vdb/__mock/tcvectordb.py:90:13
 ERROR Argument `xinference_client.types.Embedding | None` is not assignable to parameter `embedding` with type `tcvectordb.model.collection_view.Embedding` in function `tcvectordb.rpc.model.collection.RPCCollection.__init__` [bad-argument-type]
@@ -1162,9 +1162,9 @@
 ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_end_user_service.py:37:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_file_service.py:68:20
+  --> tests/test_containers_integration_tests/services/test_file_service.py:69:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_file_service.py:77:20
+  --> tests/test_containers_integration_tests/services/test_file_service.py:78:20
 ERROR Argument `str` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_human_input_delivery_test.py:32:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
@@ -1534,57 +1534,57 @@
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/tasks/test_add_document_to_index_task.py:62:20
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:70:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:71:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:79:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:80:20
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:292:23
+   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:293:23
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:666:27
+   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:667:27
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:95:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:96:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:104:20
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:105:20
 ERROR `>` is not supported between `None` and `Literal[0]` [unsupported-operation]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:311:16
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:312:16
 ERROR `>` is not supported between `None` and `Literal[0]` [unsupported-operation]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:703:16
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:704:16
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:110:20
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:111:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:120:20
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:121:20
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:295:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:296:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:298:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:299:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:407:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:408:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:410:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:411:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:475:36
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:476:36
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:478:26
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:479:26
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:530:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:531:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:533:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:534:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:615:36
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:616:36
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:618:26
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:619:26
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:728:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:729:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:731:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:732:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:814:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:815:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:817:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:818:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:969:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:970:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:972:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:973:22
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
   --> tests/test_containers_integration_tests/tasks/test_clean_notion_document_task.py:89:23
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
@@ -1966,7 +1966,7 @@
 ERROR Object of class `tuple` has no attribute `json` [missing-attribute]
    --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:192:16
 ERROR Object of class `BadRequest` has no attribute `data` [missing-attribute]
-    --> tests/unit_tests/controllers/console/datasets/test_datasets.py:1634:16
+    --> tests/unit_tests/controllers/console/datasets/test_datasets.py:1635:16
 ERROR Module `services.errors.chunk` exists, but was not imported explicitly. You are relying on other modules to load it. [implicit-import]
    --> tests/unit_tests/controllers/console/datasets/test_datasets_segments.py:891:29
 ERROR Module `services.errors.chunk` exists, but was not imported explicitly. You are relying on other modules to load it. [implicit-import]

@tmimmanuel tmimmanuel force-pushed the refactor/enum-storage-type branch from ca4e2a9 to 1e15a59 Compare March 19, 2026 05:10
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-19 05:11:21.933324995 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-19 05:11:11.962374257 +0000
@@ -438,11 +438,11 @@
 ERROR `None` is not subscriptable [unsupported-operation]
    --> core/rag/extractor/watercrawl/provider.py:141:16
 ERROR Pyrefly detected conflicting types while breaking a dependency cycle: `str | Any | None` is not assignable to `None`. Adding explicit type annotations might possibly help. [bad-assignment]
-   --> core/rag/extractor/word_extractor.py:371:13
+   --> core/rag/extractor/word_extractor.py:372:13
 ERROR Pyrefly detected conflicting types while breaking a dependency cycle: `str | Any | None` is not assignable to `None`. Adding explicit type annotations might possibly help. [bad-assignment]
-   --> core/rag/extractor/word_extractor.py:392:25
+   --> core/rag/extractor/word_extractor.py:393:25
 ERROR Object of class `BaseOxmlElement` has no attribute `body` [missing-attribute]
-   --> core/rag/extractor/word_extractor.py:425:24
+   --> core/rag/extractor/word_extractor.py:426:24
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
    --> core/rag/index_processor/processor/paragraph_index_processor.py:194:33
 ERROR Object of class `Document` has no attribute `score` [missing-attribute]
@@ -606,15 +606,15 @@
 ERROR `unpatch` may be uninitialized [unbound-name]
   --> tests/integration_tests/plugin/__mock/http.py:62:9
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:609:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:610:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:619:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:620:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:630:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:631:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:639:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:640:21
 ERROR Object of class `TestWorkflowDraftVariableServiceResetVariable` has no attribute `_test_user_id` [missing-attribute]
-   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:805:21
+   --> tests/integration_tests/services/test_workflow_draft_variable_service.py:806:21
 ERROR Argument `Index | None` is not assignable to parameter `index` with type `Index` in function `tcvectordb.rpc.model.collection.RPCCollection.__init__` [bad-argument-type]
   --> tests/integration_tests/vdb/__mock/tcvectordb.py:90:13
 ERROR Argument `xinference_client.types.Embedding | None` is not assignable to parameter `embedding` with type `tcvectordb.model.collection_view.Embedding` in function `tcvectordb.rpc.model.collection.RPCCollection.__init__` [bad-argument-type]
@@ -1162,9 +1162,9 @@
 ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_end_user_service.py:37:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_file_service.py:68:20
+  --> tests/test_containers_integration_tests/services/test_file_service.py:69:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_file_service.py:77:20
+  --> tests/test_containers_integration_tests/services/test_file_service.py:78:20
 ERROR Argument `str` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_human_input_delivery_test.py:32:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
@@ -1534,57 +1534,57 @@
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/tasks/test_add_document_to_index_task.py:62:20
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:70:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:71:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:79:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:80:20
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:292:23
+   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:293:23
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:666:27
+   --> tests/test_containers_integration_tests/tasks/test_batch_clean_document_task.py:667:27
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:95:20
+  --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:96:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:104:20
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:105:20
 ERROR `>` is not supported between `None` and `Literal[0]` [unsupported-operation]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:311:16
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:312:16
 ERROR `>` is not supported between `None` and `Literal[0]` [unsupported-operation]
-   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:703:16
+   --> tests/test_containers_integration_tests/tasks/test_batch_create_segment_to_index_task.py:704:16
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:110:20
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:111:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:120:20
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:121:20
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:295:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:296:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:298:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:299:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:407:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:408:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:410:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:411:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:475:36
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:476:36
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:478:26
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:479:26
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:530:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:531:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:533:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:534:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:615:36
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:616:36
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:618:26
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:619:26
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:728:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:729:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:731:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:732:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:814:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:815:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:817:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:818:22
 ERROR Argument `str | None` is not assignable to parameter `indexing_technique` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:969:32
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:970:32
 ERROR Argument `str | None` is not assignable to parameter `doc_form` with type `str` in function `celery.app.task.Task.__call__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:972:22
+   --> tests/test_containers_integration_tests/tasks/test_clean_dataset_task.py:973:22
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
   --> tests/test_containers_integration_tests/tasks/test_clean_notion_document_task.py:89:23
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
@@ -1966,7 +1966,7 @@
 ERROR Object of class `tuple` has no attribute `json` [missing-attribute]
    --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:192:16
 ERROR Object of class `BadRequest` has no attribute `data` [missing-attribute]
-    --> tests/unit_tests/controllers/console/datasets/test_datasets.py:1634:16
+    --> tests/unit_tests/controllers/console/datasets/test_datasets.py:1635:16
 ERROR Module `services.errors.chunk` exists, but was not imported explicitly. You are relying on other modules to load it. [implicit-import]
    --> tests/unit_tests/controllers/console/datasets/test_datasets_segments.py:891:29
 ERROR Module `services.errors.chunk` exists, but was not imported explicitly. You are relying on other modules to load it. [implicit-import]
@@ -3314,7 +3314,7 @@
 ERROR Object of class `BlobChunkMessage` has no attribute `text`
 ERROR Object of class `BlobChunkMessage` has no attribute `json_object`
 ERROR No matching overload found for function `list.__init__` called with arguments: (Generator[Unknown] | None) [no-matching-overload]
-   --> tests/unit_tests/core/datasource/test_datasource_file_manager.py:403:20
+   --> tests/unit_tests/core/datasource/test_datasource_file_manager.py:404:20
 ERROR Object of class `FunctionType` has no attribute `assert_called_once` [missing-attribute]
   --> tests/unit_tests/core/datasource/test_datasource_manager.py:52:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `datasource_type` with type `DatasourceProviderType` in function `core.datasource.datasource_manager.DatasourceManager.get_datasource_plugin_provider` [bad-argument-type]

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2026
@asukaminato0721 asukaminato0721 merged commit e4f1d3c into langgenius:main Mar 19, 2026
14 checks passed
@tmimmanuel
Copy link
Contributor Author

tmimmanuel commented Mar 19, 2026

@asukaminato0721 Thanks.

@tmimmanuel tmimmanuel deleted the refactor/enum-storage-type branch March 19, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asukaminato0721 asukaminato0721 asukaminato0721 approved these changes

@JohnJyong JohnJyong Awaiting requested review from JohnJyong JohnJyong is a code owner

@laipz8200 laipz8200 Awaiting requested review from laipz8200 laipz8200 is a code owner

@QuantumGhost QuantumGhost Awaiting requested review from QuantumGhost QuantumGhost is a code owner

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer refactor size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmimmanuel @asukaminato0721