Skip to content

fix: compatible with emoji/object icons in plugin card icon resolver#33732

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
IthacaDream:fix/tool-icon
Mar 19, 2026
Merged

fix: compatible with emoji/object icons in plugin card icon resolver#33732
crazywoola merged 1 commit intolanggenius:mainfrom
IthacaDream:fix/tool-icon

Conversation

@IthacaDream
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #33731

This PR updates the plugin card icon resolver to handle non-string (emoji/object) icons in addition to URL strings, enabling plugin cards to render AppIcon-style icons consistently.

Changes:

  • Expanded getPluginCardIconUrl parameter type to accept { content: string; background: string }.
  • Added an early return to pass object icons through without URL transformation.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 19, 2026
@github-actions github-actions bot added the web This relates to changes on the web. label Mar 19, 2026
@dosubot dosubot bot added the javascript Pull requests that update javascript code label Mar 19, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2026
@crazywoola crazywoola merged commit 0166cbf into langgenius:main Mar 19, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tool icon doesn’t support emoji icons

2 participants