Skip to content

refactor: use EnumText for MessageFeedback and MessageFile columns#33738

Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom
tmimmanuel:refactor/enum-feedback-message-file
Mar 19, 2026
Merged

refactor: use EnumText for MessageFeedback and MessageFile columns#33738
asukaminato0721 merged 1 commit intolanggenius:mainfrom
tmimmanuel:refactor/enum-feedback-message-file

Conversation

@tmimmanuel
Copy link
Contributor

@tmimmanuel tmimmanuel commented Mar 19, 2026

Summary

  • Replace sa.String with EnumText(FeedbackRating) for MessageFeedback.rating
  • Replace sa.String with EnumText(FeedbackFromSource) for MessageFeedback.from_source
  • Replace sa.String with EnumText(MessageFileBelongsTo) for MessageFile.belongs_to
  • Create new FeedbackRating enum (like, dislike)
  • Update 10 source files and 6 test files to use enum values

Continues #33294 (message domain)

Details

Model Column Before After
MessageFeedback.rating String(255) EnumText(FeedbackRating)
MessageFeedback.from_source String(255) EnumText(FeedbackFromSource)
MessageFile.belongs_to String(255) EnumText(MessageFileBelongsTo)

Test plan

  • basedpyright passes (0 errors on changed files)
  • 65 unit tests pass (message_service, feedback_service, message_api)

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 19, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. refactor labels Mar 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-19 06:58:13.669171151 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-19 06:58:04.856060217 +0000
@@ -12,6 +12,8 @@
    --> controllers/console/app/site.py:122:5
 ERROR Argument `str | None` is not assignable to parameter `language` with type `str` in function `services.account_service.AccountService.send_email_register_email` [bad-argument-type]
   --> controllers/console/auth/email_register.py:78:108
+ERROR Argument `Literal['dislike', 'like'] | None` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> controllers/console/explore/message.py:119:24
 ERROR Argument `WorkflowRun | None` is not assignable to parameter `workflow_run` with type `WorkflowRun` in function `services.workflow_event_snapshot_service.build_workflow_event_stream` [bad-argument-type]
    --> controllers/console/human_input_form.py:183:42
 ERROR Object of class `NoneType` has no attribute `tenant_id` [missing-attribute]
@@ -34,6 +36,10 @@
   --> controllers/console/version.py:30:2
 ERROR `result` may be uninitialized [unbound-name]
   --> controllers/service_api/app/annotation.py:55:16
+ERROR Argument `Literal['dislike', 'like'] | None` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> controllers/service_api/app/message.py:119:24
+ERROR Argument `Literal['dislike', 'like'] | None` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> controllers/web/message.py:160:24
 ERROR Argument `WorkflowRun | None` is not assignable to parameter `workflow_run` with type `WorkflowRun` in function `services.workflow_event_snapshot_service.build_workflow_event_stream` [bad-argument-type]
   --> controllers/web/workflow_events.py:89:42
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
@@ -586,7 +592,7 @@
 ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `AppStatus | SQLCoreOperations[AppStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
   --> tests/integration_tests/controllers/console/app/test_chat_message_permissions.py:30:22
 ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `AppStatus | SQLCoreOperations[AppStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-  --> tests/integration_tests/controllers/console/app/test_feedback_export_api.py:31:22
+  --> tests/integration_tests/controllers/console/app/test_feedback_export_api.py:32:22
 ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `AppStatus | SQLCoreOperations[AppStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
   --> tests/integration_tests/controllers/console/app/test_model_config_permissions.py:28:22
 ERROR Attribute `current_tenant_id` of class `Account` is a read-only property and cannot be set [read-only]
@@ -940,31 +946,31 @@
 ERROR Argument `Literal['archive']` is not assignable to parameter `value` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
     --> tests/test_containers_integration_tests/services/test_account_service.py:3334:25
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:133:38
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:134:38
 ERROR `str` is not assignable to attribute `agent_mode` with type `Never` [bad-assignment]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:137:47
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:138:47
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:248:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:249:29
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:274:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:275:29
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:563:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:564:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:564:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:565:24
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:798:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:799:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:799:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:800:24
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:893:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:894:29
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:962:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:963:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:963:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:964:24
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_agent_service.py:1003:29
+    --> tests/test_containers_integration_tests/services/test_agent_service.py:1004:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_agent_service.py:1004:24
+    --> tests/test_containers_integration_tests/services/test_agent_service.py:1005:24
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
    --> tests/test_containers_integration_tests/services/test_annotation_service.py:101:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
@@ -1168,17 +1174,25 @@
 ERROR Argument `str` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_human_input_delivery_test.py:32:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_message_export_service.py:52:20
+  --> tests/test_containers_integration_tests/services/test_message_export_service.py:53:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_message_export_service.py:57:63
+  --> tests/test_containers_integration_tests/services/test_message_export_service.py:58:63
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_message_service.py:118:38
+   --> tests/test_containers_integration_tests/services/test_message_service.py:119:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_message_service.py:121:81
+   --> tests/test_containers_integration_tests/services/test_message_service.py:122:81
+ERROR Argument `Literal['like']` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> tests/test_containers_integration_tests/services/test_message_service.py:412:72
+ERROR Argument `Literal['like']` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> tests/test_containers_integration_tests/services/test_message_service.py:463:72
+ERROR Argument `Literal['dislike']` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> tests/test_containers_integration_tests/services/test_message_service.py:470:72
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
    --> tests/test_containers_integration_tests/services/test_messages_clean_service.py:112:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
    --> tests/test_containers_integration_tests/services/test_messages_clean_service.py:120:20
+ERROR Argument `Literal['api']` is not assignable to parameter `from_source` with type `FeedbackFromSource | SQLCoreOperations[FeedbackFromSource]` in function `models.model.MessageFeedback.__init__` [bad-argument-type]
+   --> tests/test_containers_integration_tests/services/test_messages_clean_service.py:220:25
 ERROR Argument `Literal['local_file']` is not assignable to parameter `transfer_method` with type `FileTransferMethod | SQLCoreOperations[FileTransferMethod]` in function `models.model.MessageFile.__init__` [bad-argument-type]
    --> tests/test_containers_integration_tests/services/test_messages_clean_service.py:250:29
 ERROR Argument `Literal['end_user']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageFile.__init__` [bad-argument-type]
@@ -2155,6 +2169,10 @@
    --> tests/unit_tests/controllers/service_api/app/test_message.py:182:31
 ERROR Argument value `Literal[102]` violates Pydantic `le` constraint `Literal[101]` for field `limit` [bad-argument-type]
    --> tests/unit_tests/controllers/service_api/app/test_message.py:187:31
+ERROR Argument `Literal['like']` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> tests/unit_tests/controllers/service_api/app/test_message.py:313:20
+ERROR Argument `Literal['like']` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> tests/unit_tests/controllers/service_api/app/test_message.py:329:24
 ERROR Argument `list[dict[str, Any]] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
   --> tests/unit_tests/controllers/service_api/app/test_workflow.py:92:20
 ERROR Argument value `Literal[0]` violates Pydantic `ge` constraint `Literal[1]` for field `page` [bad-argument-type]
@@ -5760,6 +5778,10 @@
   --> tests/unit_tests/services/test_file_service.py:48:41
 ERROR `in` is not supported between `Literal['form_id=test-form']` and `None` [not-iterable]
    --> tests/unit_tests/services/test_human_input_service.py:312:12
+ERROR Argument `Literal['like']` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> tests/unit_tests/services/test_message_service.py:823:20
+ERROR Argument `Literal['dislike']` is not assignable to parameter `rating` with type `FeedbackRating | None` in function `services.message_service.MessageService.create_feedback` [bad-argument-type]
+   --> tests/unit_tests/services/test_message_service.py:855:20
 ERROR No matching overload found for function `_pytest.raises.raises` called with arguments: (tuple[type[ValueError], type[TypeError]]) [no-matching-overload]
   --> tests/unit_tests/services/test_metadata_bug_complete.py:17:27
 ERROR Argument `None` is not assignable to parameter `type` with type `Literal['number', 'string', 'time']` in function `services.entities.knowledge_entities.knowledge_entities.MetadataArgs.__init__` [bad-argument-type]

@tmimmanuel tmimmanuel force-pushed the refactor/enum-feedback-message-file branch from 0953df5 to d9d54fd Compare March 19, 2026 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

Pyrefly Diff

base → PR 
--- /tmp/pyrefly_base.txt	2026-03-19 12:14:26.365548778 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-19 12:14:16.482285363 +0000
@@ -586,7 +586,7 @@
 ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `AppStatus | SQLCoreOperations[AppStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
   --> tests/integration_tests/controllers/console/app/test_chat_message_permissions.py:30:22
 ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `AppStatus | SQLCoreOperations[AppStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
-  --> tests/integration_tests/controllers/console/app/test_feedback_export_api.py:31:22
+  --> tests/integration_tests/controllers/console/app/test_feedback_export_api.py:32:22
 ERROR Argument `Literal['normal']` is not assignable to parameter `value` with type `AppStatus | SQLCoreOperations[AppStatus]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
   --> tests/integration_tests/controllers/console/app/test_model_config_permissions.py:28:22
 ERROR Attribute `current_tenant_id` of class `Account` is a read-only property and cannot be set [read-only]
@@ -940,31 +940,31 @@
 ERROR Argument `Literal['archive']` is not assignable to parameter `value` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
     --> tests/test_containers_integration_tests/services/test_account_service.py:3334:25
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:133:38
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:134:38
 ERROR `str` is not assignable to attribute `agent_mode` with type `Never` [bad-assignment]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:137:47
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:138:47
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:248:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:249:29
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:274:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:275:29
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:563:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:564:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:564:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:565:24
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:798:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:799:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:799:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:800:24
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:893:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:894:29
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:962:29
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:963:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-   --> tests/test_containers_integration_tests/services/test_agent_service.py:963:24
+   --> tests/test_containers_integration_tests/services/test_agent_service.py:964:24
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole | SQLCoreOperations[CreatorUserRole]` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_agent_service.py:1003:29
+    --> tests/test_containers_integration_tests/services/test_agent_service.py:1004:29
 ERROR Argument `str | None` is not assignable to parameter `created_by` with type `SQLCoreOperations[str] | str` in function `models.model.MessageAgentThought.__init__` [bad-argument-type]
-    --> tests/test_containers_integration_tests/services/test_agent_service.py:1004:24
+    --> tests/test_containers_integration_tests/services/test_agent_service.py:1005:24
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
    --> tests/test_containers_integration_tests/services/test_annotation_service.py:101:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
@@ -1168,13 +1168,13 @@
 ERROR Argument `str` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_human_input_delivery_test.py:32:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_message_export_service.py:52:20
+  --> tests/test_containers_integration_tests/services/test_message_export_service.py:53:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
-  --> tests/test_containers_integration_tests/services/test_message_export_service.py:57:63
+  --> tests/test_containers_integration_tests/services/test_message_export_service.py:58:63
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_message_service.py:118:38
+   --> tests/test_containers_integration_tests/services/test_message_service.py:119:38
 ERROR Object of class `NoneType` has no attribute `id` [missing-attribute]
-   --> tests/test_containers_integration_tests/services/test_message_service.py:121:81
+   --> tests/test_containers_integration_tests/services/test_message_service.py:122:81
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
    --> tests/test_containers_integration_tests/services/test_messages_clean_service.py:112:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
@@ -2144,17 +2144,17 @@
 ERROR Missing argument `session` in function `services.conversation_service.ConversationService.pagination_by_last_id` [missing-argument]
    --> tests/unit_tests/controllers/service_api/app/test_conversation.py:383:59
 ERROR Argument value `Literal[0]` violates Pydantic `ge` constraint `Literal[1]` for field `limit` [bad-argument-type]
-  --> tests/unit_tests/controllers/service_api/app/test_message.py:93:63
+  --> tests/unit_tests/controllers/service_api/app/test_message.py:94:63
 ERROR Argument value `Literal[101]` violates Pydantic `le` constraint `Literal[100]` for field `limit` [bad-argument-type]
-  --> tests/unit_tests/controllers/service_api/app/test_message.py:99:63
+   --> tests/unit_tests/controllers/service_api/app/test_message.py:100:63
 ERROR Argument `str | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
-   --> tests/unit_tests/controllers/service_api/app/test_message.py:137:20
+   --> tests/unit_tests/controllers/service_api/app/test_message.py:138:20
 ERROR Argument value `Literal[0]` violates Pydantic `ge` constraint `Literal[1]` for field `page` [bad-argument-type]
-   --> tests/unit_tests/controllers/service_api/app/test_message.py:169:31
+   --> tests/unit_tests/controllers/service_api/app/test_message.py:170:31
 ERROR Argument value `Literal[0]` violates Pydantic `ge` constraint `Literal[1]` for field `limit` [bad-argument-type]
-   --> tests/unit_tests/controllers/service_api/app/test_message.py:182:31
+   --> tests/unit_tests/controllers/service_api/app/test_message.py:183:31
 ERROR Argument value `Literal[102]` violates Pydantic `le` constraint `Literal[101]` for field `limit` [bad-argument-type]
-   --> tests/unit_tests/controllers/service_api/app/test_message.py:187:31
+   --> tests/unit_tests/controllers/service_api/app/test_message.py:188:31
 ERROR Argument `list[dict[str, Any]] | None` is not assignable to parameter `obj` with type `Sized` in function `len` [bad-argument-type]
   --> tests/unit_tests/controllers/service_api/app/test_workflow.py:92:20
 ERROR Argument value `Literal[0]` violates Pydantic `ge` constraint `Literal[1]` for field `page` [bad-argument-type]

@tmimmanuel
Copy link
Contributor Author

tmimmanuel commented Mar 19, 2026 •
edited
Loading

@asukaminato0721 I've made an another PR. Can you review my PR please?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2026
@asukaminato0721 asukaminato0721 merged commit 5b9cb55 into langgenius:main Mar 19, 2026
14 checks passed
@tmimmanuel
Copy link
Contributor Author

tmimmanuel commented Mar 19, 2026

Thank you.

@tmimmanuel tmimmanuel deleted the refactor/enum-feedback-message-file branch March 19, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asukaminato0721 asukaminato0721 asukaminato0721 approved these changes

@laipz8200 laipz8200 Awaiting requested review from laipz8200 laipz8200 is a code owner

@QuantumGhost QuantumGhost Awaiting requested review from QuantumGhost QuantumGhost is a code owner

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmimmanuel @asukaminato0721