fix: Add dataset_id filters to the hit_count's subqueries

[FFXN]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fixes: #33756
Querying document list based on hit_count caused slow SQL, so add dataset_id filters to the hit_count's subqueries.

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a performance issue where querying document lists based on hit_count resulted in slow SQL queries. The change optimizes these queries by introducing a dataset_id filter directly into the hit_count subqueries, ensuring that only relevant data is processed and significantly speeding up the data retrieval process.

Highlights

• SQL Query Optimization: Added a dataset_id filter to the hit_count subqueries to improve performance when querying document lists.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Pyrefly Diff

No changes detected.

[github-actions]

Pyrefly Diff

No changes detected.

[Copilot]

Pull request overview

This PR addresses a performance issue when listing dataset documents sorted by hit_count by constraining the DocumentSegment aggregation subquery to the current dataset_id, avoiding unnecessary scans.

Changes:

• Add a dataset_id filter to the hit_count aggregation subquery used for sorting documents.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

The pull request addresses a performance issue by adding a dataset_id filter to the hit_count subqueries. This change is crucial for optimizing database queries and should significantly improve the efficiency of fetching document lists based on hit counts. The implementation is straightforward and directly targets the identified bottleneck.

[github-actions]

Pyrefly Diff

No changes detected.

[github-actions]

Pyrefly Diff

No changes detected.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.13%. Comparing base (df0ded2) to head (6c7963a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #33757      +/-   ##
==========================================
- Coverage   77.13%   77.13%   -0.01%     
==========================================
  Files        4356     4356              
  Lines      175245   175245              
  Branches    33477    33477              
==========================================
- Hits       135170   135169       -1     
  Misses      36826    36826              
- Partials     3249     3250       +1     

Flag	Coverage Δ
api	76.65% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hj24]

LGTM