fix: fix chunk not display in indexed document

[fatelei]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #33941

Screenshots

Before	After
...	...

before

Screen.Recording.2026-03-24.at.09.53.44.mov

after

Screen.Recording.2026-03-23.at.19.20.02.mov

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug that prevented chunks from being displayed in indexed documents. It also refactors the data source handling logic to accommodate different file formats and ensures that only valid file IDs are used for indexing parameter estimation, improving the reliability and accuracy of document processing.

Highlights

• Bug Fix: Addresses an issue where chunks were not displayed correctly in indexed documents, as reported in issue document preview block not work in indexed document #33941.
• Data Source Handling: Improves the handling of data sources by differentiating between legacy upload_file format and the new upload_file_id format.
• File ID Filtering: Ensures that only valid file IDs (non-null/undefined) are included when estimating indexing parameters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

Fixes the document settings “preview chunks” panel for indexed documents by ensuring the correct file identifiers are passed through to the indexing-estimate request, including handling a newer data_source_info shape.

Changes:

• Filter out falsy/empty file IDs before sending file_ids in the indexing estimate request.
• Populate files in document settings when data_source_info provides upload_file_id (new format), restoring preview/estimate behavior for indexed documents.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
web/service/knowledge/use-create-dataset.ts	Ensures file_ids excludes falsy IDs before calling the indexing estimate API.
web/app/components/datasets/documents/detail/settings/document-settings.tsx	Adds support for data_source_info.upload_file_id so settings mode can construct a usable files list for preview/estimate.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request addresses an issue where document chunks were not being displayed. The fix involves updating the logic to correctly handle a new file identifier format (upload_file_id) in the document settings component. Additionally, the code for estimating indexing has been improved to filter out invalid file IDs, making it more robust. My review includes a suggestion to improve type safety and consistency in type assertions within the document settings component.