test: migrate dataset service create dataset tests to testcontainers

[Desel72]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

• Migrate SQL-related tests from api/tests/unit_tests/services/test_dataset_service_create_dataset.py
  to testcontainers integration tests at
  api/tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py.

• This PR removes the mock-based unit test file that patched db.session and current_user
  with Mock objects, and replaces it with an integration test that creates real Tenant
  and Account records in PostgreSQL via testcontainers. The current_user validation
  path is preserved with a lightweight stub since it is a Flask context-local.

Part of #32454

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the testing strategy for the DatasetService's dataset creation functionality. It transitions from isolated, mock-dependent unit tests to more robust integration tests that leverage testcontainers to interact with a real PostgreSQL database. This change aims to provide more accurate and reliable testing of database interactions while maintaining coverage for critical validation paths.

Highlights

• Test Migration: Migrated SQL-related tests for DatasetService.create_empty_rag_pipeline_dataset from mock-based unit tests to integration tests using testcontainers.
• Testing Approach: Replaced mock-based unit tests that patched db.session and current_user with integration tests that interact with real PostgreSQL instances via testcontainers.
• Current User Validation: Preserved the current_user validation path with a lightweight stub in the new integration tests to ensure proper error handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-03-23 12:17:24.070060993 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-23 12:17:15.068045876 +0000
@@ -1145,6 +1145,8 @@
   --> tests/test_containers_integration_tests/services/test_dataset_service.py:37:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_dataset_service.py:39:58
+ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
+  --> tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py:35:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_dataset_service_delete_dataset.py:22:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]

[gemini-code-assist]

Code Review

This pull request successfully migrates a unit test for DatasetService.create_empty_rag_pipeline_dataset to a testcontainers-based integration test. The new test correctly uses a real database instance for setup and preserves the validation logic for current_user. The changes are well-structured. I have a couple of minor suggestions to improve the test code's readability by using standard mocking practices.

[github-actions]

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-03-23 12:30:16.305086799 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-23 12:30:06.885042520 +0000
@@ -1147,6 +1147,8 @@
   --> tests/test_containers_integration_tests/services/test_dataset_service.py:37:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_dataset_service.py:39:58
+ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
+  --> tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py:35:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_dataset_service_delete_dataset.py:22:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]

[github-actions]

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-03-23 13:03:59.327053477 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-23 13:03:50.068738296 +0000
@@ -1148,6 +1148,8 @@
   --> tests/test_containers_integration_tests/services/test_dataset_service.py:39:58
 ERROR Argument `Literal['invalid_action']` is not assignable to parameter `action` with type `Literal['archive', 'disable', 'enable', 'un_archive']` in function `services.dataset_service.DocumentService.batch_update_document_status` [bad-argument-type]
    --> tests/test_containers_integration_tests/services/test_dataset_service_batch_update_document_status.py:711:64
+ERROR Argument `Literal['owner']` is not assignable to parameter `role` with type `SQLCoreOperations[TenantAccountRole] | TenantAccountRole` in function `models.account.TenantAccountJoin.__init__` [bad-argument-type]
+  --> tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py:35:18
 ERROR Argument `Literal['active']` is not assignable to parameter `status` with type `AccountStatus | SQLCoreOperations[AccountStatus]` in function `models.account.Account.__init__` [bad-argument-type]
   --> tests/test_containers_integration_tests/services/test_dataset_service_delete_dataset.py:22:20
 ERROR Argument `Literal['normal']` is not assignable to parameter `status` with type `SQLCoreOperations[TenantStatus] | TenantStatus` in function `models.account.Tenant.__init__` [bad-argument-type]