Skip to content

test: remove mock-based tests superseded by testcontainers#33946

Merged
asukaminato0721 merged 2 commits intolanggenius:mainfrom
Desel72:test/remove-migrated-mock-tests-delete-archived-workflow-run
Mar 23, 2026
Merged

test: remove mock-based tests superseded by testcontainers#33946
asukaminato0721 merged 2 commits intolanggenius:mainfrom
Desel72:test/remove-migrated-mock-tests-delete-archived-workflow-run

Conversation

@Desel72
Copy link
Copy Markdown
Contributor

@Desel72 Desel72 commented Mar 23, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Remove mock-based unit test files that are fully superseded by existing testcontainers
integration tests:

  • api/tests/unit_tests/services/test_delete_archived_workflow_run.py (57 lines) —
    covered by test_containers_integration_tests/services/test_delete_archived_workflow_run.py (143 lines)
    which tests against real WorkflowRun and WorkflowArchiveLog records in PostgreSQL.

  • api/tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py (30 lines) —
    covered by test_containers_integration_tests/services/workflow/test_workflow_node_execution_service_repository.py (436 lines)
    which exercises all repository methods against a real database.

Part of #32454

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 23, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the project's test suite by eliminating redundant unit tests. By removing mock-based tests that have been superseded by more thorough integration tests utilizing Testcontainers, the PR aims to streamline the testing process, reduce maintenance burden, and enhance the overall reliability of the test coverage. This change ensures that testing efforts are concentrated on more realistic scenarios, leveraging actual database interactions.

Highlights

  • Test Suite Refinement: Removed two mock-based unit test files that were fully superseded by existing and more comprehensive Testcontainers integration tests.
  • Redundancy Elimination: The removed tests for ArchivedWorkflowRunDeletion and WorkflowNodeExecutionServiceRepository are now covered by integration tests that interact with real PostgreSQL databases, ensuring more robust validation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-23 12:21:47.033704146 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-23 12:21:36.243680071 +0000
@@ -6168,8 +6168,6 @@
    --> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:171:19
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_service.WorkflowService.test_human_input_delivery` [bad-argument-type]
    --> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:172:17
-ERROR Cannot instantiate `DifyAPISQLAlchemyWorkflowNodeExecutionRepository` because the following members are abstract: `save`, `save_execution_data`, `get_by_workflow_run` [bad-instantiation]
-  --> tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py:14:64
 ERROR Argument `dict[str, dict[str, bool | str] | dict[str, bool] | dict[str, dict[str, bool | int | list[str]]] | list[Unknown] | str]` is not assignable to parameter `features` with type `dict[str, object]` in function `_create_workflow` [bad-argument-type]
   --> tests/unit_tests/services/workflow/test_workflow_restore.py:62:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_restore.apply_published_workflow_snapshot_to_draft` [bad-argument-type]

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes two mock-based unit test files that are now superseded by testcontainers-based integration tests. This is a positive refactoring that streamlines the test suite by replacing mocked tests with tests that run against a real database, providing more confidence in the code's behavior. The changes consist only of file deletions and are well-justified in the pull request description.

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-23 12:29:07.053889813 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-23 12:28:57.882895680 +0000
@@ -5954,8 +5954,6 @@
    --> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:171:19
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_service.WorkflowService.test_human_input_delivery` [bad-argument-type]
    --> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:172:17
-ERROR Cannot instantiate `DifyAPISQLAlchemyWorkflowNodeExecutionRepository` because the following members are abstract: `save`, `save_execution_data`, `get_by_workflow_run` [bad-instantiation]
-  --> tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py:14:64
 ERROR Argument `dict[str, dict[str, bool | str] | dict[str, bool] | dict[str, dict[str, bool | int | list[str]]] | list[Unknown] | str]` is not assignable to parameter `features` with type `dict[str, object]` in function `_create_workflow` [bad-argument-type]
   --> tests/unit_tests/services/workflow/test_workflow_restore.py:62:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_restore.apply_published_workflow_snapshot_to_draft` [bad-argument-type]

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 23, 2026
@asukaminato0721 asukaminato0721 merged commit 65223c8 into langgenius:main Mar 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants