test: remove mock-based tests superseded by testcontainers#33946
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on optimizing the project's test suite by eliminating redundant unit tests. By removing mock-based tests that have been superseded by more thorough integration tests utilizing Testcontainers, the PR aims to streamline the testing process, reduce maintenance burden, and enhance the overall reliability of the test coverage. This change ensures that testing efforts are concentrated on more realistic scenarios, leveraging actual database interactions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-03-23 12:21:47.033704146 +0000
+++ /tmp/pyrefly_pr.txt 2026-03-23 12:21:36.243680071 +0000
@@ -6168,8 +6168,6 @@
--> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:171:19
ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_service.WorkflowService.test_human_input_delivery` [bad-argument-type]
--> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:172:17
-ERROR Cannot instantiate `DifyAPISQLAlchemyWorkflowNodeExecutionRepository` because the following members are abstract: `save`, `save_execution_data`, `get_by_workflow_run` [bad-instantiation]
- --> tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py:14:64
ERROR Argument `dict[str, dict[str, bool | str] | dict[str, bool] | dict[str, dict[str, bool | int | list[str]]] | list[Unknown] | str]` is not assignable to parameter `features` with type `dict[str, object]` in function `_create_workflow` [bad-argument-type]
--> tests/unit_tests/services/workflow/test_workflow_restore.py:62:18
ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_restore.apply_published_workflow_snapshot_to_draft` [bad-argument-type]
|
There was a problem hiding this comment.
Code Review
This pull request removes two mock-based unit test files that are now superseded by testcontainers-based integration tests. This is a positive refactoring that streamlines the test suite by replacing mocked tests with tests that run against a real database, providing more confidence in the code's behavior. The changes consist only of file deletions and are well-justified in the pull request description.
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-03-23 12:29:07.053889813 +0000
+++ /tmp/pyrefly_pr.txt 2026-03-23 12:28:57.882895680 +0000
@@ -5954,8 +5954,6 @@
--> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:171:19
ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_service.WorkflowService.test_human_input_delivery` [bad-argument-type]
--> tests/unit_tests/services/workflow/test_workflow_human_input_delivery.py:172:17
-ERROR Cannot instantiate `DifyAPISQLAlchemyWorkflowNodeExecutionRepository` because the following members are abstract: `save`, `save_execution_data`, `get_by_workflow_run` [bad-instantiation]
- --> tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py:14:64
ERROR Argument `dict[str, dict[str, bool | str] | dict[str, bool] | dict[str, dict[str, bool | int | list[str]]] | list[Unknown] | str]` is not assignable to parameter `features` with type `dict[str, object]` in function `_create_workflow` [bad-argument-type]
--> tests/unit_tests/services/workflow/test_workflow_restore.py:62:18
ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.workflow_restore.apply_published_workflow_snapshot_to_draft` [bad-argument-type]
|
Important
Fixes #<issue number>.Summary
Remove mock-based unit test files that are fully superseded by existing testcontainers
integration tests:
api/tests/unit_tests/services/test_delete_archived_workflow_run.py(57 lines) —covered by
test_containers_integration_tests/services/test_delete_archived_workflow_run.py(143 lines)which tests against real
WorkflowRunandWorkflowArchiveLogrecords in PostgreSQL.api/tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py(30 lines) —covered by
test_containers_integration_tests/services/workflow/test_workflow_node_execution_service_repository.py(436 lines)which exercises all repository methods against a real database.
Part of #32454
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods