test: migrate dataset service document indexing tests to testcontainers#34022
Merged
asukaminato0721 merged 3 commits intolanggenius:mainfrom Mar 24, 2026
Conversation
Contributor
Pyrefly DiffNo changes detected. |
api/tests/test_containers_integration_tests/services/test_dataset_service.py
Outdated
Show resolved
Hide resolved
asukaminato0721
requested changes
Mar 24, 2026
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
approved these changes
Mar 24, 2026
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Migrate remaining mock-based dataset service document indexing tests from
api/tests/unit_tests/services/test_dataset_service.py(129 lines, 4 tests) intothe existing testcontainers integration test at
api/tests/test_containers_integration_tests/services/test_dataset_service.py(708 lines, 22 tests).
The existing testcontainers file covered dataset CRUD, permission checks, and retrieval
model updates. This PR adds 4 new tests for document pause/recover/retry orchestration
(state transitions, DB commits, Redis flags, Celery task dispatch). External services
(Redis, Celery) remain mocked. Then removes the fully superseded 129-line mock-based file.
Part of #32454
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods