Skip to content

feat: support editable class labels in question classifier#34075

Open
Blackoutta wants to merge 7 commits intolanggenius:mainfrom
Blackoutta:feature/question-classifier-custom-label-1
Open

feat: support editable class labels in question classifier#34075
Blackoutta wants to merge 7 commits intolanggenius:mainfrom
Blackoutta:feature/question-classifier-custom-label-1

Conversation

@Blackoutta
Copy link
Copy Markdown
Contributor

Fixes #33806

Summary

This PR adds editable branch labels to the Question Classifier node while preserving the existing classifier behavior.

Changes included:

  • add an optional label field to Question Classifier classes
  • support inline label editing in the right-side settings panel
  • keep class_name as the original descriptive topic/class text
  • add a separate class_label output for downstream nodes
  • render labels and descriptive text consistently across the panel, canvas node card, and workflow preview
  • preserve user-provided casing for custom labels instead of forcing uppercase in the UI
  • keep backward compatibility by falling back to canonical default labels like CLASS 1 when no custom label is set
  • add i18n coverage for English, Simplified Chinese, Traditional Chinese, and Japanese
  • add frontend and backend regression tests for label editing, fallback behavior, rendering, and runtime outputs

Motivation:
The current Question Classifier only exposes class names/topics and uses fixed branch titles. This change lets users define a human-friendly branch label separately, display it consistently in the workflow UI, and consume it downstream via class_label without changing the existing class_name behavior.

Verification performed:

  • backend unit tests for Question Classifier runtime outputs and fallback label behavior
  • frontend integration tests for inline label editing, node rendering, preview rendering, and output vars
  • frontend type check
  • pre-commit lint/test hooks passed during commit

Screenshots

qc-demo

Before After
Question Classifier branches only showed fixed CLASS N titles and did not expose a separate label output. Question Classifier branches support editable labels, show descriptive topic text separately, and expose class_label for downstream use.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

…values to be passed from classifiers to down stream nodes.
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 25, 2026
@github-actions github-actions bot added the web This relates to changes on the web. label Mar 25, 2026
@dosubot dosubot bot added 🌊 feat:workflow Workflow related stuff. 💪 enhancement New feature or request labels Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-25 09:17:25.959558372 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-25 09:17:13.910537393 +0000
@@ -6409,9 +6409,13 @@
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `dify_graph.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_list_operator.py:60:16
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:92:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:96:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `dify_graph.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:100:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:104:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:140:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `dify_graph.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:148:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `dify_graph.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:34:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-25 09:18:02.473080703 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-25 09:17:50.949071392 +0000
@@ -6409,9 +6409,13 @@
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `dify_graph.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_list_operator.py:60:16
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:92:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:96:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `dify_graph.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:100:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:104:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:140:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `dify_graph.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:148:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `dify_graph.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:34:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-25 09:22:26.466529562 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-25 09:22:16.084592296 +0000
@@ -6409,9 +6409,13 @@
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `dify_graph.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_list_operator.py:60:16
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:92:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:96:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `dify_graph.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:100:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:104:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:140:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `dify_graph.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:148:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `dify_graph.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:34:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

@Blackoutta Blackoutta force-pushed the feature/question-classifier-custom-label-1 branch from b36a997 to 0c4f737 Compare March 26, 2026 02:12
@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-26 02:13:50.905924703 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-26 02:13:40.174836249 +0000
@@ -6527,9 +6527,13 @@
 ERROR `SimpleNamespace` is not assignable to attribute `graph_runtime_state` with type `GraphRuntimeState` [bad-assignment]
    --> tests/unit_tests/core/workflow/nodes/test_loop_node.py:135:32
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:93:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:97:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:101:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:105:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:141:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:149:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `graphon.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:37:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-26 02:17:36.822716278 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-26 02:17:25.693724238 +0000
@@ -6527,9 +6527,13 @@
 ERROR `SimpleNamespace` is not assignable to attribute `graph_runtime_state` with type `GraphRuntimeState` [bad-assignment]
    --> tests/unit_tests/core/workflow/nodes/test_loop_node.py:135:32
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:93:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:97:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:101:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:105:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:141:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:149:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `graphon.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:37:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]
@@ -6951,7 +6955,7 @@
 ERROR Could not import `MetadataValue` from `services.entities.knowledge_entities.knowledge_entities` [missing-module-attribute]
   --> tests/unit_tests/services/dataset_metadata.py:95:5
 ERROR Cannot find module `dify_graph.model_runtime.entities.model_entities` [missing-import]
-  --> tests/unit_tests/services/dataset_service_test_helpers.py:19:1
+  --> tests/unit_tests/services/dataset_service_test_helpers.py:13:1
 ERROR Argument `str` is not assignable to parameter `indexing_technique` with type `Literal['economy', 'high_quality']` in function `services.entities.knowledge_entities.rag_pipeline_entities.KnowledgeConfiguration.__init__` [bad-argument-type]
    --> tests/unit_tests/services/dataset_service_test_helpers.py:449:28
 ERROR Argument `Literal['']` is not assignable to parameter `plan` with type `CloudPlan` in function `DocumentIndexingTaskProxyTestDataFactory.create_mock_features` [bad-argument-type]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-26 06:28:44.182818356 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-26 06:28:32.434706883 +0000
@@ -6527,9 +6527,13 @@
 ERROR `SimpleNamespace` is not assignable to attribute `graph_runtime_state` with type `GraphRuntimeState` [bad-assignment]
    --> tests/unit_tests/core/workflow/nodes/test_loop_node.py:135:32
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:93:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:97:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:101:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:105:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:141:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:149:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `graphon.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:37:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-26 07:09:20.749358348 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-26 07:09:10.492122055 +0000
@@ -6527,9 +6527,13 @@
 ERROR `SimpleNamespace` is not assignable to attribute `graph_runtime_state` with type `GraphRuntimeState` [bad-assignment]
    --> tests/unit_tests/core/workflow/nodes/test_loop_node.py:135:32
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:93:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:97:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:101:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:105:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:141:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:149:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `graphon.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:37:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-27 02:20:44.667454216 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 02:20:33.550402306 +0000
@@ -6507,9 +6507,13 @@
 ERROR `SimpleNamespace` is not assignable to attribute `graph_runtime_state` with type `GraphRuntimeState` [bad-assignment]
    --> tests/unit_tests/core/workflow/nodes/test_loop_node.py:135:32
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:93:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:97:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:101:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:105:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:141:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:149:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `graphon.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:37:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-03-27 06:45:00.455605077 +0000
+++ /tmp/pyrefly_pr.txt	2026-03-27 06:44:49.328315790 +0000
@@ -6507,9 +6507,13 @@
 ERROR `SimpleNamespace` is not assignable to attribute `graph_runtime_state` with type `GraphRuntimeState` [bad-assignment]
    --> tests/unit_tests/core/workflow/nodes/test_loop_node.py:135:32
 ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
-  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:93:42
+  --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:97:42
 ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
-   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:101:29
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:105:29
+ERROR `dict[str, Any]` is not assignable to TypedDict key `data` with type `BaseNodeData` [bad-typed-dict-key]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:141:42
+ERROR Argument `SimpleNamespace` is not assignable to parameter `graph_runtime_state` with type `GraphRuntimeState` in function `graphon.nodes.question_classifier.question_classifier_node.QuestionClassifierNode.__init__` [bad-argument-type]
+   --> tests/unit_tests/core/workflow/nodes/test_question_classifier_node.py:149:29
 ERROR Argument `dict[str, dict[str, Any] | str]` is not assignable to parameter `config` with type `NodeConfigDict` in function `graphon.nodes.base.node.Node.__init__` [bad-argument-type]
   --> tests/unit_tests/core/workflow/nodes/test_start_node_json_object.py:37:16
 ERROR `Literal['{invalid-json-schema']` is not assignable to attribute `json_schema` with type `dict[str, Any] | None` [bad-assignment]

class ClassConfig(BaseModel):
id: str
name: str
label: str | None = None
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding some comments to the three fields, especially for name and field since they are quite similar and confusing.

The name field is actually the description of the correspond class, AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request 🌊 feat:workflow Workflow related stuff. size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customizable Class Name/Title in Question Classifier

2 participants