Skip to content

test: migrate restore archived workflow run tests to testcontainers#34083

Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom
YB0y:test/migrate-restore-archived-workflow-run-tests-to-testcontainers
Mar 25, 2026
Merged

test: migrate restore archived workflow run tests to testcontainers#34083
asukaminato0721 merged 1 commit intolanggenius:mainfrom
YB0y:test/migrate-restore-archived-workflow-run-tests-to-testcontainers

Conversation

@YB0y
Copy link
Copy Markdown
Contributor

@YB0y YB0y commented Mar 25, 2026

Summary

Migrate tests from api/tests/unit_tests/services/test_restore_archived_workflow_run.py
to testcontainers integration tests at
api/tests/test_containers_integration_tests/services/test_restore_archived_workflow_run.py.

Added two pure-logic tests (test_restore_initialization, test_convert_datetime_fields) to the existing TC file, which already covered test_restore_table_records_returns_rowcount and test_restore_table_records_unknown_table. Deleted the unit test file.

Part of #32454

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues.
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

No changes detected.

@YB0y
Copy link
Copy Markdown
Contributor Author

YB0y commented Mar 25, 2026

@asukaminato0721 Could you please review this?

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2026
@asukaminato0721 asukaminato0721 merged commit b7b9b00 into langgenius:main Mar 25, 2026
14 checks passed
@YB0y YB0y deleted the test/migrate-restore-archived-workflow-run-tests-to-testcontainers branch April 1, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants