fix(api): add spacing around human input form urls#34189
Draft
Theysua wants to merge 1 commit intolanggenius:mainfrom
Draft
fix(api): add spacing around human input form urls#34189Theysua wants to merge 1 commit intolanggenius:mainfrom
Theysua wants to merge 1 commit intolanggenius:mainfrom
Conversation
When {{#url#}} is adjacent to non-whitespace text in a Human Input email
delivery body, the rendered URL was concatenated directly with surrounding
characters, producing broken links (e.g. "Approval:https://...").
Fix by replacing the simple str.replace call with a regex substitution
that inspects the characters immediately before and after the placeholder
and inserts a space where none exists.
Fixes langgenius#34160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When {{#url#}} is adjacent to non-whitespace text in a Human Input email delivery body, the rendered URL was concatenated directly with surrounding characters, producing broken links (e.g. "Approval:https://...").
Fix by replacing the simple str.replace call with a regex substitution that inspects the characters immediately before and after the placeholder and inserts a space where none exists.
Fixes #34160
Important
Fixes #<issue number>.Summary
Screenshots
| Before | After |

Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods