test: migrate web forgot password controller tests to testcontainers#34288
Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom Mar 30, 2026
Conversation
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate tests from
api/tests/unit_tests/controllers/web/test_web_forgot_password.pyto testcontainers integration tests atapi/tests/test_containers_integration_tests/controllers/web/test_web_forgot_password.py.Replaced
Flask(__name__)withflask_app_with_containersfixture. All 5 tests migrated: email normalization before sending reset email, email normalization for validity checks, token email case preservation, account fetching with case fallback, and password update with commit verification. External services (AccountService, Session, db) remain mocked as tests verify controller routing and email normalization logic.Part of #32454
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods