Skip to content

refactor(api): clean redundant type ignore in request query parsing 🤖🤖🤖#34350

Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom
majiayu000:codex/issue-24494-type-ignore-b1
Mar 31, 2026
Merged

refactor(api): clean redundant type ignore in request query parsing 🤖🤖🤖#34350
asukaminato0721 merged 1 commit intolanggenius:mainfrom
majiayu000:codex/issue-24494-type-ignore-b1

Conversation

@majiayu000
Copy link
Copy Markdown
Contributor

@majiayu000 majiayu000 commented Mar 31, 2026

Summary

  • remove redundant # type: ignore comments from request query parsing in 5 console controllers
  • keep runtime behavior unchanged (pure typing/refactor cleanup)

Changes

  • api/controllers/console/billing/billing.py
  • api/controllers/console/billing/compliance.py
  • api/controllers/console/workspace/account.py
  • api/controllers/console/workspace/workspace.py
  • api/controllers/console/workspace/model_providers.py

Verification

  • uv run --directory api --dev pyrefly check controllers/console/billing/billing.py controllers/console/billing/compliance.py controllers/console/workspace/account.py controllers/console/workspace/workspace.py controllers/console/workspace/model_providers.py
  • make type-check-core
  • uv run --project api pytest api/tests/unit_tests/controllers/console/billing/test_billing.py api/tests/unit_tests/controllers/console/workspace/test_workspace.py api/tests/unit_tests/controllers/console/workspace/test_model_providers.py api/tests/unit_tests/controllers/console/test_workspace_account.py

fixes #24494

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. refactor labels Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

No changes detected.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 31, 2026
@asukaminato0721 asukaminato0721 added this pull request to the merge queue Mar 31, 2026
Merged via the queue into langgenius:main with commit 19530e8 Mar 31, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer needs-revision refactor size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore/Refactor] clean some # type: ignore

2 participants