fix(web): prevent PortalSelect dropdown from being obscured in dialogs 🤖🤖🤖#34351
Open
majiayu000 wants to merge 1 commit intolanggenius:mainfrom
Open
fix(web): prevent PortalSelect dropdown from being obscured in dialogs 🤖🤖🤖#34351majiayu000 wants to merge 1 commit intolanggenius:mainfrom
majiayu000 wants to merge 1 commit intolanggenius:mainfrom
Conversation
majiayu000
requested review from
CodingOnStar,
hyoban,
iamjoel and
zxhlyh
as code owners
dosubot
bot
added
the
size:S
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PortalSelectpopup layer toz-[1001]so dropdown options render above dialog content layersWhy
Issue #27581 reports dropdown options being obscured when opened inside dialog contexts.
The previous
z-20layer can be lower than current dialog migration layers.Files
web/app/components/base/select/index.tsxweb/app/components/base/select/__tests__/index.spec.tsxVerification
./node_modules/.bin/vp test run app/components/base/select/__tests__/index.spec.tsx./node_modules/.bin/vp run lint:ci app/components/base/select/index.tsx app/components/base/select/__tests__/index.spec.tsx./node_modules/.bin/vp run lint:tss./node_modules/.bin/vp run type-checkfixes #27581