Skip to content

fix: fix online_drive is not a valid datasource_type#34440

Merged
fatelei merged 1 commit intolanggenius:mainfrom
fatelei:issue-34439
Apr 2, 2026
Merged

fix: fix online_drive is not a valid datasource_type#34440
fatelei merged 1 commit intolanggenius:mainfrom
fatelei:issue-34439

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented Apr 2, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #34439

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-04-02 04:22:04.712012755 +0000
+++ /tmp/pyrefly_pr.txt	2026-04-02 04:21:53.055066559 +0000
@@ -3011,7 +3011,7 @@
 ERROR Cannot index into `str` [bad-index]
    --> tests/unit_tests/core/app/apps/pipeline/test_pipeline_generate_response_converter.py:112:12
 ERROR Class `PipelineRunner` has no class attribute `call_args` [missing-attribute]
-   --> tests/unit_tests/core/app/apps/pipeline/test_pipeline_generator.py:340:12
+   --> tests/unit_tests/core/app/apps/pipeline/test_pipeline_generator.py:341:12
 ERROR Argument `SimpleNamespace` is not assignable to parameter `application_generate_entity` with type `RagPipelineGenerateEntity` in function `core.app.apps.pipeline.pipeline_runner.PipelineRunner.__init__` [bad-argument-type]
   --> tests/unit_tests/core/app/apps/pipeline/test_pipeline_runner.py:65:37
 ERROR Argument `SimpleNamespace` is not assignable to parameter `application_generate_entity` with type `RagPipelineGenerateEntity` in function `core.app.apps.pipeline.pipeline_runner.PipelineRunner.__init__` [bad-argument-type]

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 2, 2026
@fatelei fatelei added this pull request to the merge queue Apr 2, 2026
Merged via the queue into langgenius:main with commit 993a301 Apr 2, 2026
27 checks passed
@fatelei fatelei deleted the issue-34439 branch April 2, 2026 04:55
volcano303 pushed a commit to volcano303/dify that referenced this pull request Apr 7, 2026
HanqingZ pushed a commit to HanqingZ/dify that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<DatasourceProviderType.ONLINE_DRIVE: 'online_drive'> is not a valid DataSourceType

2 participants