refactor(api): type log identity dict with IdentityDict TypedDict#34485
Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom Apr 3, 2026
Merged
Conversation
dosubot
Bot
added
size:S
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
approved these changes
Apr 3, 2026
2 tasks
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IdentityDictTypedDict (total=False) with keystenant_id,user_id,user_type_extract_identityand its local variableWhy this change
_extract_identityreturns a dict with 3 well-known optional keys but was typed asdict[str, str] | None. The TypedDict withtotal=Falsedocuments exactly which keys can appear, matching the structured JSON log schema documented in the class docstring.Changes
core/logging/structured_formatter.py: DefineIdentityDict, update return type and local variable annotationTest plan
ruff checkpassesPart of #32863 (
core/logging/structured_formatter.py)