fix(web): restore ui select public exports#34501
Merged
Conversation
hyoban
approved these changes
Apr 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34501 +/- ##
==========================================
- Coverage 86.84% 82.92% -3.92%
==========================================
Files 2997 4139 +1142
Lines 151441 175008 +23567
Branches 29713 36221 +6508
==========================================
+ Hits 131513 145134 +13621
- Misses 17150 26999 +9849
- Partials 2778 2875 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectGroup,SelectGroupLabel, andSelectSeparatorin thebase/ui/selectwrapperWhy
base/ui/selectis the replacement primitive for legacy select during overlay migration, so its group-related exports should remain part of the public API even if current call sites have not migrated yet.Validation
pnpm exec vp test app/components/base/ui/select/__tests__/index.spec.tsxpnpm exec knip