Skip to content

fix(web): restore ui select public exports#34501

Merged
lyzno1 merged 2 commits intomainfrom
codex/restore-ui-select-public-exports
Apr 3, 2026
Merged

fix(web): restore ui select public exports#34501
lyzno1 merged 2 commits intomainfrom
codex/restore-ui-select-public-exports

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented Apr 3, 2026

Summary

  • restore SelectGroup, SelectGroupLabel, and SelectSeparator in the base/ui/select wrapper
  • add an alias export spec so these public wrapper exports stay protected from future knip cleanup

Why

base/ui/select is the replacement primitive for legacy select during overlay migration, so its group-related exports should remain part of the public API even if current call sites have not migrated yet.

Validation

  • pnpm exec vp test app/components/base/ui/select/__tests__/index.spec.tsx
  • pnpm exec knip

@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 3, 2026
@lyzno1 lyzno1 marked this pull request as ready for review April 3, 2026 04:29
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. javascript Pull requests that update javascript code labels Apr 3, 2026
@lyzno1 lyzno1 enabled auto-merge April 3, 2026 04:31
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 3, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 3, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.92%. Comparing base (608958d) to head (9c0e81d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #34501      +/-   ##
==========================================
- Coverage   86.84%   82.92%   -3.92%     
==========================================
  Files        2997     4139    +1142     
  Lines      151441   175008   +23567     
  Branches    29713    36221    +6508     
==========================================
+ Hits       131513   145134   +13621     
- Misses      17150    26999    +9849     
- Partials     2778     2875      +97     
Flag Coverage Δ
web 83.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit a263f28 Apr 3, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the codex/restore-ui-select-public-exports branch April 3, 2026 04:50
HanqingZ pushed a commit to HanqingZ/dify that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants