refactor: migrate session.query to select API in console controllers#34607
Merged
asukaminato0721 merged 2 commits intolanggenius:mainfrom Apr 7, 2026
Merged
Conversation
aliworksx08
requested review from
JohnJyong,
Mairuis,
QuantumGhost and
Yeuoly
as code owners
dosubot
Bot
added
size:S
Contributor
Author
|
Hi, @asukaminato0721 |
aliworksx08
force-pushed
the
refactor/sqlalchemy-select-controllers
branch
from
a0876e5 to
ca2e12a
Compare
aliworksx08
force-pushed
the
refactor/sqlalchemy-select-controllers
branch
from
ca2e12a to
4d68421
Compare
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
requested changes
Apr 7, 2026
5 tasks
auto-merge was automatically disabled
April 7, 2026 03:54
Head branch was pushed to by a user without write access
Contributor
Author
|
Hi, @asukaminato0721 Thanks for your help. Please review my update. |
asukaminato0721
previously approved these changes
Apr 7, 2026
Contributor
Pyrefly DiffNo changes detected. |
auto-merge was automatically disabled
April 7, 2026 04:09
Head branch was pushed to by a user without write access
aliworksx08
force-pushed
the
refactor/sqlalchemy-select-controllers
branch
from
f188f32 to
7228f61
Compare
dosubot
Bot
added
size:M
Contributor
Author
|
@asukaminato0721 Sorry. Please rerun CI tests. Thanks |
asukaminato0721
approved these changes
Apr 7, 2026
Contributor
Pyrefly DiffNo changes detected. |
Contributor
Author
|
@asukaminato0721 Thanks for merging this PR. I'll continue. |
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.query(Model).where(...).first()to modernsession.scalar(select(Model).where(...))in controller filesPart of #22668
Changes
controllers/console/workspace/__init__.py— plugin permission lookupcontrollers/console/app/workflow_trigger.py— webhook trigger lookupcontrollers/console/datasets/rag_pipeline/rag_pipeline.py— pipeline template lookupcontrollers/mcp/mcp.py— MCP server, app, and end user lookupsTest plan
ruff checkpassesmake type-check— no new errors