fix(workflow): correct env variable picker validation#34666
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34666 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 4170 4170
Lines 176792 176801 +9
Branches 35358 35368 +10
=======================================
+ Hits 148074 148082 +8
- Misses 25838 25839 +1
Partials 2880 2880
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hjlarry
approved these changes
Apr 7, 2026
6 tasks
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The picker refactor in #34013 split validation and rendering logic.
envselectors were still treated as valid in helper logic, but the trigger rendered the red error icon wheneveroutputVarNodehad notitle. Because environment variables are workflow-level data rather than graph nodes, they do not have source node metadata and were incorrectly flagged as errors.Impact
Validation
pnpm --dir web test app/components/workflow/nodes/_base/components/variable/__tests__/var-reference-picker.helpers.spec.ts app/components/workflow/nodes/_base/components/variable/__tests__/var-reference-picker.branches.spec.tsxpnpm --dir web type-check:tsgo,pnpm --dir web knip