refactor(api): deduplicate shared auth request payloads into auth_entities.py#34694
Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom Apr 7, 2026
Merged
Conversation
dosubot
Bot
added
size:L
…s/shared/auth_entities.py refactor(api): extract LoginPayloadBase into shared auth entities refactor(api): move shared auth entities to services/entities/auth_entities.py fix
corevibe555
force-pushed
the
refactor/shared-auth-payloads
branch
from
9663d02 to
20b1aa0
Compare
corevibe555
changed the title
Contributor
Pyrefly DiffNo changes detected. |
1 similar comment
Contributor
Pyrefly DiffNo changes detected. |
asukaminato0721
approved these changes
Apr 7, 2026
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #32385.
Summary
LoginPayloadBase(email + password fields) intoservices/entities/auth_entities.pyas a shared base classForgotPasswordSendPayload,ForgotPasswordCheckPayload,ForgotPasswordResetPayloadinto the same shared moduleLoginPayloadinherits base and adds password format validator; consoleLoginPayloadinherits base and addsremember_me/invite_tokenfieldscontrollers/web/login.py,controllers/console/auth/login.py,controllers/web/forgot_password.py,controllers/console/auth/forgot_password.pyWhy this change
ForgotPasswordSendPayload,ForgotPasswordCheckPayload, andForgotPasswordResetPayloadwere defined identically in bothweb/forgot_password.pyandconsole/auth/forgot_password.py.LoginPayloadshared the sameemail/passwordcore acrossweb/login.pyandconsole/auth/login.pywith minor field additions per controller.Consolidating into
services/entities/follows Dify's existing pattern (services/entities/knowledge_entities/,services/entities/model_provider_entities.py) and ensures a single source of truth for auth request schemas.Changes
services/entities/auth_entities.py: New file —LoginPayloadBase,ForgotPasswordSendPayload,ForgotPasswordCheckPayload,ForgotPasswordResetPayloadcontrollers/web/forgot_password.py: Remove 3 class definitions, import from shared modulecontrollers/console/auth/forgot_password.py: Remove 3 class definitions, import from shared modulecontrollers/web/login.py:LoginPayloadextendsLoginPayloadBase, adds password validatorcontrollers/console/auth/login.py:LoginPayloadextendsLoginPayloadBase, addsremember_me/invite_tokenTest plan
ruff checkpasses