refactor(api): tighten types in trivial lint and config fixes#34773
Merged
asukaminato0721 merged 2 commits intolanggenius:mainfrom Apr 8, 2026
Merged
refactor(api): tighten types in trivial lint and config fixes#34773asukaminato0721 merged 2 commits intolanggenius:mainfrom
asukaminato0721 merged 2 commits intolanggenius:mainfrom
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-04-08 21:32:17.735052780 +0000
+++ /tmp/pyrefly_pr.txt 2026-04-08 21:32:08.758993040 +0000
@@ -62,8 +62,6 @@
--> core/rag/datasource/keyword/jieba/jieba.py:157:29
ERROR Argument `object` is not assignable to parameter `iterable` with type `Iterable[@_]` in function `list.__init__` [bad-argument-type]
--> core/rag/datasource/keyword/jieba/jieba_keyword_table_handler.py:88:35
-ERROR Class member `AnalyticdbVector.add_texts` overrides parent class `BaseVector` in an inconsistent manner [bad-override]
- --> core/rag/datasource/vdb/analyticdb/analyticdb_vector.py:43:9
ERROR Argument `str | None` is not assignable to parameter `namespace_password` with type `str` in function `alibabacloud_gpdb20160503.models._create_namespace_request.CreateNamespaceRequest.__init__` [bad-argument-type]
--> core/rag/datasource/vdb/analyticdb/analyticdb_vector_openapi.py:120:40
ERROR Argument `str | None` is not assignable to parameter `namespace_password` with type `str` in function `alibabacloud_gpdb20160503.models._describe_collection_request.DescribeCollectionRequest.__init__` [bad-argument-type]
|
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-04-08 21:33:58.874034827 +0000
+++ /tmp/pyrefly_pr.txt 2026-04-08 21:33:49.096996705 +0000
@@ -62,8 +62,6 @@
--> core/rag/datasource/keyword/jieba/jieba.py:157:29
ERROR Argument `object` is not assignable to parameter `iterable` with type `Iterable[@_]` in function `list.__init__` [bad-argument-type]
--> core/rag/datasource/keyword/jieba/jieba_keyword_table_handler.py:88:35
-ERROR Class member `AnalyticdbVector.add_texts` overrides parent class `BaseVector` in an inconsistent manner [bad-override]
- --> core/rag/datasource/vdb/analyticdb/analyticdb_vector.py:43:9
ERROR Argument `str | None` is not assignable to parameter `namespace_password` with type `str` in function `alibabacloud_gpdb20160503.models._create_namespace_request.CreateNamespaceRequest.__init__` [bad-argument-type]
--> core/rag/datasource/vdb/analyticdb/analyticdb_vector_openapi.py:120:40
ERROR Argument `str | None` is not assignable to parameter `namespace_password` with type `str` in function `alibabacloud_gpdb20160503.models._describe_collection_request.DescribeCollectionRequest.__init__` [bad-argument-type]
|
asukaminato0721
approved these changes
Apr 8, 2026
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
…nius#34773) Co-authored-by: tmimmanuel <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> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpcimport and fixPointsargument type in qdrant vector adapterSettings,DEFAULT_TENANT,DEFAULT_DATABASE) and fixresultsredeclaration_create_collection_if_not_exists→create_collection_if_not_existsin analyticdb adapters (called externally)Iterator[Any]return type to_get_cursorcontext manager in analyticdb SQL adapterpgvecto_rs.sqlalchemytoallowedUntypedLibrariesin pyrightconfigTest plan
make type-check-corepasses with 0 errorsanalyticdb,qdrant,chroma,relyt,unstructured)Part of #26412