refactor: convert file-transfer-method-pipeline if/elif to match/case (#30001)#34788
Merged
asukaminato0721 merged 2 commits intolanggenius:mainfrom Apr 9, 2026
Conversation
dosubot
Bot
added
size:M
Contributor
Pyrefly DiffNo changes detected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors prepare_file_dict() in the task pipeline to use match/case on the FileTransferMethod enum, aligning with the codebase goal of making enum branching more explicit and easier to keep exhaustive as new transfer methods are added.
Changes:
- Replaced
if/elifbranching onmessage_file.transfer_methodwithmatch/case. - Kept existing URL/filename/extension derivation logic for
REMOTE_URL,LOCAL_FILE, andTOOL_FILE(including guarded handling whenmessage_file.urlis present).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asukaminato0721
approved these changes
Apr 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Pyrefly DiffNo changes detected. |
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
…langgenius#30001) (langgenius#34788) Co-authored-by: Asuka Minato <i@asukaminato.eu.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Convert
if/elifchains ontransfer_method pipelineenum to exhaustivematch/casestatements inmessage_file_utils.py.Part of #30001.
Files changed
api/core/app/task_pipeline/message_file_utils.pyAll tests passed.