fix(#34636): replace SimpleNamespace with model instances in feedback…#34866
Open
CUIRJKS wants to merge 1 commit intolanggenius:mainfrom
Open
fix(#34636): replace SimpleNamespace with model instances in feedback…#34866CUIRJKS wants to merge 1 commit intolanggenius:mainfrom
CUIRJKS wants to merge 1 commit intolanggenius:mainfrom
Conversation
…n feedback export tests
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34636
Summary
This PR updates the feedback export integration test to use real model instances instead of
SimpleNamespacetest doubles.SimpleNamespaceobjects withMessage,Conversation, andAppinstances in the feedback export testMessagefields used by the export flow, includingapp_idandmessageNo additional dependencies are required.
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods